fix: map remaining user-input errors to 4xx and restore 0.1.0 invariants - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9441
createdAfter/createdBeforeoutside years 1 to 9999 return 400.?version=, the versions cursor andexpectedVersionabove the int4 max (MAX_VERSION) return 400, on both the tenant and workflow mounts.POST /artifacts/binaryandlink-filemapArtifactSizeErrorto 400.readArtifactthrowsArtifactNotFoundErrorfor a missing version, so workflowread?version=returns 404.0005_schema_invariantsadds 0.1.0'sartifact_version_gte_1,artifact_version_version_gte_1andupload_size_gte_0CHECKs when missing, and setsartifact.tenant_id NOT NULLwhen it is nullable and has no NULLs. Otherwise it leaves the column alone and the runner logs the warning viaconsole.warn.