Repository navigation
Allow explicit Doctrine transport factory configuration - #33
Merged
Merged
Conversation
Add test case verifying that explicitly defining transportFactory.doctrine in NEON works correctly. Fix duplicate service registration bug in TransportFactoryPass when doctrine factory is both user-defined and auto-discovered via ConnectionRegistry. https://claude.ai/code/session_015tqPb45KBUxcxpsePPSCYG
f3l1x
force-pushed
the
claude/add-doctrine-transport-test-AOYUZ
branch
from
October 4, 2026 16:10
c2b8523 to
6ae75b6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 26 26
Lines 659 659
=======================================
Hits 632 632
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change allows the Doctrine transport factory to be explicitly configured via NEON configuration, while preventing automatic registration when a custom definition is already provided.
Key Changes
DummyConnectionRegistrymock class for testing Doctrine transport factory registrationTransportFactoryPassto check if a Doctrine transport factory definition already exists before auto-registering oneImplementation Details
The fix prevents duplicate Doctrine transport factory registrations by checking
hasDefinition()before adding the auto-wired definition. This allows users to explicitly define their ownmessenger.transportFactory.doctrineservice in configuration without conflicts, while maintaining backward compatibility with automatic registration when no explicit configuration is provided.https://claude.ai/code/session_015tqPb45KBUxcxpsePPSCYG