Skip to content

Allow explicit Doctrine transport factory configuration - #33

Merged
f3l1x merged 1 commit into
masterfrom
claude/add-doctrine-transport-test-AOYUZ
Oct 4, 2026
Merged

f3l1x merged 1 commit into
masterfrom
claude/add-doctrine-transport-test-AOYUZ

Conversation

@f3l1x

@f3l1x f3l1x commented Oct 4, 2026

Copy link
Copy Markdown
Member

Summary

This change allows the Doctrine transport factory to be explicitly configured via NEON configuration, while preventing automatic registration when a custom definition is already provided.

Key Changes

  • Added DummyConnectionRegistry mock class for testing Doctrine transport factory registration
  • Modified TransportFactoryPass to check if a Doctrine transport factory definition already exists before auto-registering one
  • Added test case verifying that explicitly configured Doctrine transport factory is properly registered

Implementation Details

The fix prevents duplicate Doctrine transport factory registrations by checking hasDefinition() before adding the auto-wired definition. This allows users to explicitly define their own messenger.transportFactory.doctrine service in configuration without conflicts, while maintaining backward compatibility with automatic registration when no explicit configuration is provided.

https://claude.ai/code/session_015tqPb45KBUxcxpsePPSCYG

Add test case verifying that explicitly defining transportFactory.doctrine
in NEON works correctly. Fix duplicate service registration bug in
TransportFactoryPass when doctrine factory is both user-defined and
auto-discovered via ConnectionRegistry.

https://claude.ai/code/session_015tqPb45KBUxcxpsePPSCYG
@f3l1x
f3l1x force-pushed the claude/add-doctrine-transport-test-AOYUZ branch from c2b8523 to 6ae75b6 Compare October 4, 2026 16:10
@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.90%. Comparing base (ca5a43d) to head (6ae75b6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          26       26           
  Lines         659      659           
=======================================
  Hits          632      632           
  Misses         27       27           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f3l1x
f3l1x merged commit 40a5a51 into master Oct 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants