Repository navigation
Worker: own time-limit listener for Symfony 8.1+ (v0.4.0) - #32
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 95.83% 95.90% +0.06%
==========================================
Files 25 26 +1
Lines 648 659 +11
==========================================
+ Hits 621 632 +11
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f3l1x
commented
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to v0.3.0, which was tagged from master. This PR goes into the next release.
Contributte\Messenger\EventListener\StopWorkerOnTimeLimitListener. Symfony 8.1 deprecated its own listener in favour of the per-commandtime_limitworker option, and that option can't be set globally. The new listener keepsmessenger.worker.timeLimitworking on Symfony 7.4 and 8.x without deprecation notices. It has unit tests, and the worker DI test is updated.BuilderManusesfindByTag()directly, with the tag values typed asarray<string, string>.RoutingPassgets its transport names fromBuilderMan. The redundantpriorityfallback inHandlerPassis removed, becauseAsMessageHandler::$priorityis a non-nullable int.0.4.x-dev.^0.3as stable and^0.4as dev.QA
make cs,make phpstanandmake tests(24 tests) all pass.Proposed version:
v0.4.0Draft release notes (v0.3.0...v0.4.0)
Features
StopWorkerOnTimeLimitListener, soworker.timeLimitkeeps working on Symfony 8.1+ without deprecations.Fixes
findByTag()results (fixes phpstan on current dependencies).Docs