Adjust tools, resources & prompts light theme - #47
Open
a-effort wants to merge 4 commits into
Open
Conversation
a-effort
requested review from
Yosiefeyob,
gandhipratik203,
gcgoncalves,
marekdano and
vishu-bh
August 19, 2026 06:23
Applies PR #34's light-mode pass to the three surfaces it missed. - Status tokens gain a `.dark` override; six sites that hardcoded the emerald/gray shades now use them, including the two server drawers. - Drawer body and right rail both inherit `bg-popover`. The dark-only override they carried split the panes in dark and did nothing in light, where both were pure white. - Scrim `bg-black/10` → `/50` on all five drawers. - The three drawer tables adopt `ServersTable`'s card-per-row pattern, with rows a step down from the drawer body rather than up from the page. Hover and selected are pinned to the row fill. - Page chrome moves to `text-foreground` / `text-muted-foreground`, the off-palette blue spinners are retinted, and two badges stop bypassing the icon tokens. Also fixes an unrelated bug in `VirtualServerDetailsPanel`: the status icon was unconditionally green while its label branched on `enabled`. Forms keep their hardcoded neutrals, matching what PR #34 left behind. 2896 tests pass; tsc, eslint, prettier and build are clean. Signed-off-by: Anna Effort <anna.effort@ibm.com>
a-effort
force-pushed
the
light-theme-components
branch
from
August 19, 2026 06:30
bfc7fc5 to
bdeef45
Compare
marekdano
requested changes
Aug 19, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
Blocking
ToolsTable.tsx:81,ResourcesTable.tsx:68,PromptDefinitionTable.tsx:82: the new row className sets the base,hover:, anddata-[state=selected]:backgrounds to the same color (in both light and dark), which overridesTableRow's previoushover:bg-muted/50/data-[state=selected]:bg-muted. Rows no longer show any visual feedback on hover or selection — only the DOMdata-stateattribute changes, which is why the existing "highlights selected row" tests still pass. Worth restoring a distinct hover/selected shade here.
Worth checking
MCPServerDetailsPanel.tsx:534andVirtualServerDetailsPanel.tsx:640still hardcodebg-backgroundon the right-rail<aside>, while the container now usesbg-popover(like the three sibling panels this PR fixed). In dark mode that reproduces the same split-pane look this PR resolves elsewhere. Was this intentionally left out of scope, or just missed?
Signed-off-by: Marek Dano <mk.dano@gmail.com>
…theme tokens Signed-off-by: Marek Dano <mk.dano@gmail.com>
- Grid becomes `grid-cols-1 / lg:2 / 2xl:3`. `col-span-full` and `sortServersForLayout` both go — cards are uniform now, so empty servers no longer need sorting to the end to keep a full-width row from splitting the grid. Servers render in API order. - Page shell moves from `space-y-9` to a `mb-6` heading, and the loading branch stops early-returning, so the title survives the spinner. - Cards drop `min-h-29` / `min-h-35` and their `justify-*` pairs. - New `--server-icon-bg` token joins `--tool-icon-bg` and `--prompt-icon-bg`; the card status dot stops hardcoding emerald/red and picks up `--tool-status-*`. - `ConnectSourceCard` adopts `AddToolsCard`'s add-icon token, hover and description leading. 2896 tests pass; tsc, eslint, prettier and build are clean. The e2e suite was not run — no local Chromium. Signed-off-by: Anna Effort <anna.effort@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies PR #34's light-mode pass to the three surfaces it missed.
.darkoverride; six sites that hardcoded the emerald/gray shades now use them, including the two server drawers.bg-popover. The dark-only override they carried split the panes in dark and did nothing in light, where both were pure white.bg-black/10→/50on all five drawers.ServersTable's card-per-row pattern, with rows a step down from the drawer body rather than up from the page. Hover and selected are pinned to the row fill.text-foreground/text-muted-foreground, the off-palette blue spinners are retinted, and two badges stop bypassing the icon tokens.Also fixes an unrelated bug in
VirtualServerDetailsPanel: the status icon was unconditionally green while its label branched onenabled.Forms keep their hardcoded neutrals, matching what PR #34 left behind. Also deferred:
ToolSchemaDialog's dark-only<pre>, thebg-inheritcard shells,ui/json-highlighteron a light surface inTestConnectionPanel, and--mainmatching the drawer color in dark where the design has the page darker.2896 tests pass; tsc, eslint, prettier and build are clean. Verified visually in both themes.