fix(build): break the vendor <-> vendor-react chunk cycle

[a-effort]

What

manualChunks in vite.config.ts matched packages by bare substring, so id.includes("/react-dom/") also caught @floating-ui/react-dom and swept it into vendor-react — which then imported @floating-ui/dom back out of vendor.

That makes the two chunks circular. Rollup has said so on every build for a while, buried among the chunk-size advice:

Circular chunk: vendor -> vendor-react -> vendor. Please adjust the manual chunk logic for these chunks.

Why it matters

A cycle leaves rollup to pick an execution order, and the losing side evaluates against a namespace object that doesn't exist yet. When that order flips, the app dies at module-eval and serves a blank page whose only console output is:

Uncaught TypeError: Cannot set properties of undefined (setting 'Activity')
    at vendor-react-*.js

Activity is a React 19 export, so nothing in that message points at bundling — it reads like a React or auth fault. This is how it was found: an unrelated one-component change shifted chunk composition, flipped the order, and took the whole app down.

The cycle is latent, not new. Any change that disturbs the bundle can flip it, so the failure attaches to whichever commit happened to disturb it rather than to the real cause.

The fix

Anchor the match to the package root so only the real react packages land in vendor-react, and hold that chunk to react, react-dom, scheduler, react-is. A leaf chunk imports nothing from its siblings, so it can't be one end of a cycle no matter what moves between chunks later. react-intl, @formatjs, sonner and the react-remove-scroll family move to vendor, alongside helpers they already import from there.

Verification

Circular chunk warning     gone
vendor-react cross-chunk   zero imports (true leaf)
tsc -b / eslint / prettier clean
vitest                     167 files, 2908 passed, 1 skipped

Because no CI job builds (see below), I verified the actual failure by loading the built entry chunk under jsdom and catching module-eval throws — it reproduces the browser error exactly. Before: FAIL … setting 'Activity'. After: PASS.

⚠️ CI does not cover this

No workflow runs npm run build:

workflow	runs
client-lint-test	generate, format:check, lint, test:coverage
client-generate	generate, tsc -b --noEmit
client-e2e	Playwright against npm run dev:e2e — the Vite dev server

manualChunks is a rollup build-only option, so the dev server never applies it and E2E can't see this class of bug. A PR that reintroduces the cycle goes green on every check.

Adding npm run build to client-lint-test would have caught this in seconds. Filing that separately rather than bundling it here.

Related

Blocks the avatar PR, which trips this cycle and cannot merge before this lands.

[marekdano]

Looks good!

LGTM 🚀