Improve conformance baseline reporting - #105
Merged
Merged
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
marked this pull request as ready for review
August 18, 2026 14:22
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
marked this pull request as draft
August 18, 2026 14:31
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
marked this pull request as ready for review
August 18, 2026 14:35
cafalchio
approved these changes
Aug 18, 2026
cafalchio
left a comment
Contributor
There was a problem hiding this comment.
I am not sure id make conformance bless is working.
But make conformance is more human readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
make conformanceand CIXFAIL(expected failure reproduced),FAIL(expected pass failed), andXPASS(expected failure passed)UPSTREAMresults so they do not fail the dataplane job or appear in dataplane failure detailsmake conformance-blessto refresh dataplane-owned expected failures from the current runWhy
The official runner's raw status combined dataplane baseline mismatches with known upstream fixture findings, while the local target did not run the detailed reporter. That made it hard to see which expectation changed and could fail CI for an upstream issue.
The shared reporter is now authoritative in both environments. Missing results remain an error, but pinned upstream findings are reported without being counted as dataplane failures.
Usage
Run the conformance suite and compare its results with the checked-in expectations:
After an intentional behavior change, run the suite and refresh the expected-failure baseline:
Review and commit the resulting change to
tests/conformance/expected-failures.yml.Verification
tests/conformance/report-baseline-diff-test.shshellcheck tests/conformance/report-baseline-diff.sh tests/conformance/report-baseline-diff-test.sh tests/conformance/run-conformance.sh tests/conformance/run-local.shactionlint .github/workflows/mcp_conformance.ymlmake conformance: 59 passed, 44 expected failures, 0 failed, 0 unexpected passesmake pre-commit