Added prompt and resources stateless - #103
Open
cafalchio wants to merge 18 commits into
Open
Conversation
cafalchio
force-pushed
the
prompt_resources_stateless
branch
from
August 18, 2026 15:16
c070be9 to
b604a24
Compare
cafalchio
marked this pull request as ready for review
August 18, 2026 15:21
cafalchio
force-pushed
the
prompt_resources_stateless
branch
from
August 18, 2026 15:28
b604a24 to
9468c44
Compare
dawid-nowak
previously approved these changes
Aug 19, 2026
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
lucarlig
force-pushed
the
prompt_resources_stateless
branch
from
August 19, 2026 09:22
89ca25d to
60a748e
Compare
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
cafalchio
force-pushed
the
prompt_resources_stateless
branch
from
August 19, 2026 12:38
a8e606d to
4832716
Compare
dawid-nowak
self-requested a review
August 19, 2026 13:56
dawid-nowak
previously approved these changes
Aug 19, 2026
lucarlig
requested changes
Aug 19, 2026
lucarlig
left a comment
lucarlig
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes for deterministic per-request cleanup and progress ordering. The cancellation item is intentionally excluded because it is waiting on the draft RMCP fix in modelcontextprotocol/rust-sdk#1194.
| - server-stateless:sep-2575-discover-capabilities-match-handlers | ||
| - server-stateless:sep-2575-http-server-no-independent-requests-on-stream | ||
| - server-stateless:sep-2575-server-declares-prompts-in-discover | ||
| - tools-call-with-progress:tools-call-with-progress |
Contributor
There was a problem hiding this comment.
Do not record this as a stable expected failure while it is timing-dependent. The same production code has both passed this check and missed it: RMCP runs on_progress in a detached task, while the final response can make the dataplane remove the token mapping and return first. Make the ordering deterministic by waiting for earlier progress forwarding before cleanup and the final response, add a regression test, and then remove this baseline entry.
Suggested change
| - tools-call-with-progress:tools-call-with-progress |
Signed-off-by: cafalchio <mcafalchio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same pattern from tool_call for prompt and resources.
Use connect_backend_for_request and validate_stateless to connect to prompt and resources.
Increased conformance tests from 61 to 70.
Stack created with GitHub Stacks CLI • Give Feedback 💬