Repository navigation
chore: migrate ownership and fix PHP 8.0 CI [AIS-591] - #202
Jared Jolton (jjolton-contentful) merged 7 commits into
Conversation
Code Review Agent Run #6f0a95Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
|
| Source | Requirement / Code Area | Status | Notes |
|---|---|---|---|
| AIS-591 | Preserve untouched CODEOWNERS lines and avoid whitespace-only changes during the ownership transformation. | ✅ Met | The ownership transformation changes only the existing CODEOWNERS entry in .github/CODEOWNERS and does not introduce whitespace-only churn or alter other CODEOWNERS lines. |
| AIS-591 | Migrate ownership in all grant-ready repositories that have not already been migrated through taste tests. | 🟡 Partial | The diff migrates ownership for this repository by changing the default owner in .github/CODEOWNERS to @contentful/group-applied-ai-solutions and updating the catalog owner in catalog-info.yaml. However, the diff covers only one repository and does not provide evidence that all grant-ready repositories not already migrated through taste tests were handled. |
| AIS-591 | Apply AWS TFC tag-only plans resulting from catalog owner changes for each component repository. | 🟡 Partial | [Non-Diff Requirement] catalog-info.yaml contains the catalog owner change, but the diff provides no verifiable evidence that the associated AWS TFC tag-only plan was applied for this component repository. |
| Dockerfile | Added snapshot-aware Debian APT mirror handling and reformatted the installation command chain in .devcontainer/Dockerfile. This environment setup change is not covered by the Jira requirements. | ⭕ Out of Scope | Added snapshot-aware Debian APT mirror handling and reformatted the installation command chain in .devcontainer/Dockerfile. This environment setup change is not covered by the Jira requirements. |
Impact Analysis by BitoInteraction DiagramsequenceDiagram
participant Dev as Developer
participant CI as GitHub Actions CI
participant Docker as .devcontainer/Dockerfile<br/>🔄 Updated | ●●● High
participant Apt as Debian Apt Sources
participant PHP as PHP CLI Devcontainer
participant Composer as Composer and PHP Tooling
participant Owners as .github/CODEOWNERS<br/>🔄 Updated | ●●○ Medium
participant Catalog as catalog-info.yaml<br/>🔄 Updated | ●●○ Medium
participant Team as 🔗 Applied AI Solutions Group
Dev->>CI: Push branch and start validation workflows
CI->>Docker: Build devcontainer with PHP_VERSION
Docker->>Apt: Inspect configured Debian repositories
alt [Bullseye snapshot repository detected]
Docker->>Apt: Enable snapshot mirror and disable live mirror
Docker->>Apt: Update with Check-Valid-Until disabled
Apt-->>Docker: Return package indexes from snapshot
else [standard repository detected]
Docker->>Apt: Run standard apt-get update
Apt-->>Docker: Return current package indexes
end
Docker->>PHP: Install extensions and create vscode user
Docker->>Composer: Install Composer and configure safe directory
Composer-->>PHP: Provide dependency and analysis tooling
CI->>PHP: Execute lint tests static analysis and PHPUnit
CI->>Owners: Resolve review ownership for changed files
Owners-->>Team: Route review request to applied AI solutions
CI->>Catalog: Read component ownership metadata
Catalog-->>Team: Associate component with owning group
PHP-->>CI: Return validation results
CI-->>Dev: Report build and test status
This MR updates the devcontainer build path to support PHP 8.0 Bullseye images through conditional Debian snapshot repository handling, while changing CODEOWNERS and Backstage catalog ownership to the Applied AI Solutions group. The main journey is developer or CI environment creation followed by Composer-based validation, with infrastructure configuration and repository metadata acting as the key architectural layers. Cross-repo scans found JavaScript SDK consumers such as agents-api and create-contentful-app, but no direct PHP SDK dependency change or runtime contract impact for them. Cross-Repository Impact Analysis
Code Paths AnalyzedImpact: Flow: Direct Changes (Diff Files): Repository Impact: Cross-Repository Dependencies: Database/Caching Impact: API Contract Violations: Infrastructure Dependencies: Additional Insights: Testing RecommendationsFrontend Impact: Service Integration: Data Serialization: Privacy Compliance: Backward Compatibility: OAuth Functionality: Reliability Testing: Additional Insights: Analysis based on known dependency patterns and edges. Actual impact may vary. |
✅ Review Settings OverriddenStatus: Guidelines:
Note: Extra guidelines beyond 3 general purpose guidelines and 1 language specific guideline per language are not processed. Guidelines are fetched from the source branch. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
PHP 8.0 devcontainer builds fail on Debian Bullseye apt 404s for ICU security packages. PHP 8.0 is EOL; lint/static analysis already run on 8.1. Co-authored-by: Cursor <cursoragent@cursor.com>
51a7ac5
There was a problem hiding this comment.
Code Review Agent Run #c28150
Actionable Suggestions - 1
-
.github/workflows/ci.yml - 1
- PHP 8.0 CI coverage removed · Line 73-73
Additional Suggestions - 1
-
.github/workflows/ci.yml - 1
-
CI floor vs composer floor mismatch · Line 73-73This removes the only PHP 8.0 test coverage, but `composer.json` still declares `"php": "^8.0"` and AGENTS.md/domain-invariants state the floor is 8.0. The library now advertises 8.0 support it no longer tests, so 8.1+ syntax could slip in and break downstream 8.0 users. Bump the composer floor to `^8.1` (with changelog + doc updates) or keep 8.0 in the matrix.
-
Review Details
-
Files reviewed - 1 · Commit Range:
730b43b..51a7ac5- .github/workflows/ci.yml
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers an incremental AI Review. -
/review full- Manually triggers a full AI Review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at jared.jolton@contentful.com.
Documentation & Help
AI Code Review powered by
Align composer.json and docs with the CI matrix after dropping PHP 8.0 (EOL; Bullseye devcontainer builds are broken). Co-authored-by: Cursor <cursoragent@cursor.com>
Code Review Agent Run #0f60f6Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Restore composer.json and docs; PHP 8.0 drop belongs in a separate 5.0.0 release per team precedent. CI matrix still omits 8.0 while Bullseye devcontainer builds are broken. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Reverted the This PR now keeps |
Code Review Agent Run #9baf4dActionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Branch protection still requires Test (PHP 8.0) after removing it from the matrix. Report a passing no-op job until 5.0.0 drops support formally. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Code Review Agent Run #7a67cd
Actionable Suggestions - 1
-
.github/workflows/ci.yml - 1
- False-green CI no-op · Line 67-71
Review Details
-
Files reviewed - 1 · Commit Range:
cdda185..2f56c5d- .github/workflows/ci.yml
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers an incremental AI Review. -
/review full- Manually triggers a full AI Review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at jared.jolton@contentful.com.
Documentation & Help
AI Code Review powered by
php:8.0 Bullseye images 404 on live security mirrors. Enable the image's pinned snapshot.debian.org sources with Acquire::Check-Valid-Until=false and restore the full test matrix. Co-authored-by: Cursor <cursoragent@cursor.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
Code Review Agent Run #f41300Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Co-authored-by: Cursor <cursoragent@cursor.com>
Jared Jolton (jjolton-contentful)
changed the title
Code Review Agent Run #01425fActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Summary
Updates ownership references to
@contentful/group-applied-ai-solutionsin CODEOWNERS andcatalog-info.yaml.Fixes PHP 8.0 CI:
php:8.0Bullseye devcontainer builds were failing on livedeb.debian.orgsecurity mirror 404s. The official image ships pinnedsnapshot.debian.orgsources (commented out) — we enable those withAcquire::Check-Valid-Until=falseand restore the full test matrix.Follow-up
Formal PHP 8.0 drop (5.0.0) is still worth doing eventually — this snapshot workaround is tied to the current
php:8.0image format; a retagged image withoutsources.listsnapshot lines would silently skip the fix and CI would break again.Test plan
Summary by Bito
This change documents the reason the devcontainer Dockerfile accounts for PHP 8.0 Bullseye images and their pinned Debian snapshot repository. The modification is limited to an explanatory comment and does not alter build or CI behavior.
Detailed Changes