Support doctrine/dbal 4 alongside 3 - #84
Merged
dmolineus merged 1 commit intoAug 19, 2026
Merged
Conversation
Widen the doctrine/dbal constraint to `^3.4 || ^4.0`. DBAL 4 types `AbstractSchemaManager::tablesExist()` as `array`, while DBAL 3 still accepted a string with a deprecation. The dynamic grid size column check passed a bare string, which would have raised a TypeError on every tl_bs_grid DCA load under DBAL 4. The remaining DBAL touchpoints were checked against the 4.3.0 sources and need no change: `listTableColumns()` is only ever called with the table name, and the `int|string` return type of `insert()`/`update()`/ `executeStatement()` is either cast or unused. Dependency constraints already permit DBAL-4-capable releases, so no other requirement changes: contao/core-bundle from 5.6, contao-bootstrap/core from 3.1, netzmacht/contao-toolkit from 4.0, mvo/contao-group-widget from 1.6 and meta-palettes from 2.1. On Contao 5.3-5.5 the resolver keeps selecting DBAL 3, which is why the `^3.4` half of the constraint stays.
Member
|
Thanks, released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce support of DBAL 4:
^3.4 || ^4.0AbstractSchemaManager::tablesExist()only accepts anarray, while DBAL 3 still accepted a string (with deprecation)listTableColumns()is only ever called with the table nameint|stringreturn type ofinsert()/update()/executeStatement()is either cast or unusedThe DBAL ^3.4 constraint is still required in support of older/LTS contao versions.