Fix exception due invalid item retrival - #83
Merged
Merged
Conversation
dmolineus
requested changes
Aug 13, 2026
dmolineus
left a comment
dmolineus
left a comment
Member
There was a problem hiding this comment.
LGTM. Please do not commit the .idea folder. :-) The folder is not excluded in the .gitignore by default as this should be a user specific setting.
Contributor
Author
|
I created the pr since we have multiple projects with this issue. I don't know when contao will release a patch. Even if this is also a issue of contao, we should ask if there can be a current record before asking for it, so I just changed the order of the code to do so. |
Contributor
Author
|
The idea folder was an accident, we always have gitignore files for that, sorry! :) |
koertho
marked this pull request as ready for review
August 13, 2026 09:11
dmolineus
approved these changes
Aug 13, 2026
Contributor
Author
|
Thanks! :) |
Member
|
Thanks for the fix, released as 3.1.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #82