fix(navbar): resolve logo collapse on theme toggle and improve toggle… - #747
Merged
ashley-cui merged 1 commit intoSep 16, 2026
Merged
Conversation
… hover contrast - Define explicit aspect-ratio and dimensions on .navbar__logo and its img to prevent layout shift and title collapse during theme switch (fixes containers#702) - Add translucent hover/focus-visible background for navbar theme toggle button to ensure clear visibility and contrast for the sun icon Signed-off-by: pippo <sakshiagrahari2004@gmail.com>
Member
|
LGTM, thanks! |
portgasdyamato
marked this pull request as ready for review
September 15, 2026 20:51
ashley-cui
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve logo collapse on theme toggle and improve toggle hover contrast
fixes: #745 #702