Skip to content

[codex] Improve service conflict suggestions - #224

Closed
Jonesxq wants to merge 1 commit into
containers:mainfrom
Jonesxq:fix/issue-212-cli-suggestion
Closed

Jonesxq wants to merge 1 commit into
containers:mainfrom
Jonesxq:fix/issue-212-cli-suggestion

Conversation

@Jonesxq

@Jonesxq Jonesxq commented Jul 29, 2026

Copy link
Copy Markdown

Summary

  • make existing-service conflict suggestions choose the rename option that matches the requested output path
  • explain that --skip-services-check replaces the conflicting service file and include its path
  • add regression tests for full-file and directory output modes

Why

The previous suggestion always recommended both --file and --name, even when only one option applied. It also described --skip-services-check as acceptable without explaining which existing service file would be replaced. This made conflicts confusing when the output path itself was not the source of the conflict.

Validation

  • cargo fmt --verbose --check
  • cargo test --verbose (79 tests passed)
  • cargo clippy -- -Dwarnings on Linux
  • git diff --check

Closes #212

Closes: containers#212
Signed-off-by: jones <239089032+Jonesxq@users.noreply.github.com>
@Jonesxq Jonesxq closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI inappropriately suggests --file flag when --skip-services-check is needed

1 participant