[pyramation]

Summary

pg_query_parse_plpgsql aborted with assert(proc_source != NULL) on any CREATE FUNCTION/PROCEDURE without an AS clause. That includes valid SQL-standard bodies:

CREATE FUNCTION f() RETURNS int LANGUAGE sql BEGIN ATOMIC SELECT 1; END;  -- abort
CREATE FUNCTION f() RETURNS int LANGUAGE sql;                              -- abort
CREATE PROCEDURE p() LANGUAGE plpgsql;                                     -- abort

In the WASM build (libpg-query 18.x parsePlPgSQL) this surfaces as RuntimeError: Aborted(Assertion failed: proc_source != NULL …).

This is a clean cherry-pick (-x) of upstream e275398 (pganalyze#363):

• compile_create_function_stmt_via_callback checks the language first. Non-PL/pgSQL functions are skipped as before (palloc0 function), so LANGUAGE sql … BEGIN ATOMIC returns a result.
• For PL/pgSQL, missing and duplicate bodies raise upstream's interpret_AS_clause errors: no function body specified / duplicate function body specified.
• compile_do_stmt raises no inline code specified instead of asserting.
• New regression cases in test/parse_plpgsql.c.

17-constructive has the same two asserts, but libpg-query 17 doesn't export parsePlPgSQL, so this PR only targets 18.

CI: every build passes, local make test passes. The valgrind jobs fail only on test/parse_plpgsql, with the 192-byte still-reachable block from pg_query_plpgsql_record_alias (pg_query_json_plpgsql.c:826). That failure is not caused by this PR:

• Report out of memory from pg_query_scan instead of writing through NULL #12, which doesn't touch PL/pgSQL, fails the same three valgrind jobs.
• 18: stack-depth guard, PL/pgSQL alias leak, scan out of memory (combined) #13, which includes the alias-list free, passes them.

The node pin is left to the combined fork/node PR.

Link to Devin session: https://app.devin.ai/sessions/b32426e30a71409594f003cf94c9e560
Open in Devin Desktop: https://app.devin.ai/desktop/session/b32426e30a71409594f003cf94c9e560?variant=devin
Requested by: @pyramation

[devin-ai-integration]

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

• Disable automatic comment, CI, and merge conflict monitoring

[tenki-reviewer]

Review complete. No blocking issues — approved ✅; 1 nitpick below.

🧹 Nitpicks (1) — 🟢 1 low

• 🟢 Body checks skipped for non-plpgsql languages (pg_query_parse_plpgsql.c:440) — The new checks mirroring upstream interpret_AS_clause sit after the strcmp(language, "plpgsql") != 0 early return at src/pg_query_parse_plpgsql.c:437, so they only run for plpgsql.

---

The PR ports upstream interpret_AS_clause body-existence and format checks into the plpgsql parser for CREATE FUNCTION and DO statements, so statements without bodies now return errors instead of silently parsing, and updates the test suite accordingly.

Files	Change
src/pg_query_parse_plpgsql.c	Adds body checks (no function body specified, duplicate function body specified, inline SQL body restricted to LANGUAGE SQL) in the CREATE FUNCTION path and a proc_source check in the DO path.
test/parse_plpgsql.c	Adds test fixtures covering missing and duplicate function bodies and missing DO inline code.

_{Reviewed commit: 99174d9}

[devin-ai-integration]

Folded into #13