docs(pgpm): skill accepts a developer's own Postgres; never stop what owns 5432 - #1805
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review complete. No blocking issues — approved ✅; 1 nitpick below. 🧹 Nitpicks (1) — 🟢 1 low
This PR revises the pgpm skill docs to steer users toward an existing local PostgreSQL server rather than Docker. It adds a "use your own Postgres" path across the skill, covering how to export
Reviewed commit: c58a924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only (replaces #1804, which also changed
pgpm env; that part is dropped — if you export your own PG* vars you simply don't runpgpm env).The pgpm skill told agents that "port 5432 in use" means stop the process, which during onboarding meant killing the developer's own PostgreSQL. Four
.agents/skills/pgpmfiles now say instead:pg_isready -h localhost -p 5432first. If it answers, that's the developer's Postgres: use it with their credentials (export PGHOST/PGPORT/PGUSER/PGPASSWORD,pgpm admin-users bootstrap --yes), skippgpm docker startandpgpm env, and never stop it.pgpm docker start --port 5433+export PGPORT=5433.lsofshows it isn't Postgres.ERR_PNPM_IGNORED_BUILDS: editpnpm-policy.yaml(allowBuildstrue/false) andpnpm run policy; don'tpnpm approve-builds.Companion PRs: constructive-io/pgpm-boilerplates#45, constructive-io/dev-utils#128.
Link to Devin session: https://app.devin.ai/sessions/1ef0d1c209f041afa29e0e4cc4b2cb29
Open in Devin Desktop: https://app.devin.ai/desktop/session/1ef0d1c209f041afa29e0e4cc4b2cb29?variant=devin
Requested by: @pyramation