Skip to content

docs(pgpm): skill accepts a developer's own Postgres; never stop what owns 5432 - #1805

Merged
pyramation merged 1 commit into
mainfrom
feat/pgpm-skill-byo-postgres
Sep 4, 2026
Merged

docs(pgpm): skill accepts a developer's own Postgres; never stop what owns 5432#1805
pyramation merged 1 commit into
mainfrom
feat/pgpm-skill-byo-postgres

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Docs-only (replaces #1804, which also changed pgpm env; that part is dropped — if you export your own PG* vars you simply don't run pgpm env).

The pgpm skill told agents that "port 5432 in use" means stop the process, which during onboarding meant killing the developer's own PostgreSQL. Four .agents/skills/pgpm files now say instead:

  • pg_isready -h localhost -p 5432 first. If it answers, that's the developer's Postgres: use it with their credentials (export PGHOST/PGPORT/PGUSER/PGPASSWORD, pgpm admin-users bootstrap --yes), skip pgpm docker start and pgpm env, and never stop it.
  • Want the container too? pgpm docker start --port 5433 + export PGPORT=5433.
  • Only consider stopping something on 5432 if lsof shows it isn't Postgres.
  • New troubleshooting row for ERR_PNPM_IGNORED_BUILDS: edit pnpm-policy.yaml (allowBuilds true/false) and pnpm run policy; don't pnpm approve-builds.

Companion PRs: constructive-io/pgpm-boilerplates#45, constructive-io/dev-utils#128.

Link to Devin session: https://app.devin.ai/sessions/1ef0d1c209f041afa29e0e4cc4b2cb29
Open in Devin Desktop: https://app.devin.ai/desktop/session/1ef0d1c209f041afa29e0e4cc4b2cb29?variant=devin
Requested by: @pyramation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@tenki-reviewer

tenki-reviewer Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review complete. No blocking issues — approved ✅; 1 nitpick below.

🧹 Nitpicks (1) — 🟢 1 low
  • 🟢 Truncated comment on bootstrap roles (troubleshooting.md:277) — The inline comment on pgpm admin-users bootstrap --yes at .agents/skills/pgpm/references/troubleshooting.md:277 reads # once: roles pgpm and pgsql-test expect and is cut off mid-sentence, so a reader cannot tell what the command is supposed to do.

This PR revises the pgpm skill docs to steer users toward an existing local PostgreSQL server rather than Docker. It adds a "use your own Postgres" path across the skill, covering how to export PGHOST/PGPORT/PGUSER/PGPASSWORD, run pgpm admin-users bootstrap --yes, and start the pgpm container on an alternate port (--port 5433) when both are wanted, while warning against stopping a developer's server.

Files Change
.agents/skills/pgpm/SKILL.md Adds the reuse-an-existing-server guidance to the install/start steps and the troubleshooting quick-fix table.
.agents/skills/pgpm/references/docker.md Notes Docker is optional and documents the alternate-port container path.
.agents/skills/pgpm/references/env.md Adds a "Using Your Own PostgreSQL" section and clarifies pgpm env emits container vars.
.agents/skills/pgpm/references/troubleshooting.md Reworks the port-in-use guidance to prefer an existing Postgres and adds the bootstrap-role note.

Reviewed commit: c58a924

@pyramation
pyramation merged commit c597b70 into main Sep 4, 2026
4 checks passed
@pyramation
pyramation deleted the feat/pgpm-skill-byo-postgres branch September 4, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant