[LucaCappelletti94]

CREATE INDEX ON t (s) stored the index with no name, while PostgreSQL names it t_s_idx. A later DROP INDEX t_s_idx failed with DropIndexNotFound, and CREATE TABLE t_s_idx was accepted although the server refuses it as taken.

Applying the statement now gives the index the name PostgreSQL's ChooseIndexName would give it against the catalog as it stands, so it is dropped, renamed and contested like a written one. The column part reuses the existing FigureColname port, taught the types it was missing, and counts INCLUDE columns as PostgreSQL does. A partition's copies of its root's keys go through the same code, which gives them the 63-byte cut they lacked. An expression whose PostgreSQL name the port does not model leaves the index unnamed as before, since a guessed name would be worse than none.

ParserDBIngestor::create_index_name answers the name applying a CREATE INDEX would store, so a consumer that translates the statement itself, such as pg2sqlite, can emit the same name.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!