Update module github.com/go-git/go-git/v5 to v5.18.0 [SECURITY] (main)#3250
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
Update module github.com/go-git/go-git/v5 to v5.18.0 [SECURITY] (main)#3250renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v5.17.1→v5.18.0GitHub Vulnerability Alerts
GHSA-3xc5-wrhm-f963
Impact
go-gitmay leak HTTP authentication credentials when following redirects during smart-HTTP clone and fetch operations.If a remote repository responds to the initial
/info/refsrequest with a redirect to a different host, go-git updates the session endpoint to the redirected location and reuses the original authentication for subsequent requests. This can result in the credentials (e.g. Authorization headers) being sent to an unintended host.An attacker controlling or influencing the redirect target can capture these credentials and potentially reuse them to access the victim’s repositories or other resources, depending on the scope of the credential.
Clients using
go-gitexclusively with trusted remotes (for example, GitHub or GitLab), and over a secure HTTPS connection, are not affected by this issue. The risk arises when interacting with untrusted or misconfigured Git servers, or when using unsecured HTTP connections, which is not recommended. Such configurations also expose clients to a broader class of security risks beyond this issue, including credential interception and tampering of repository data.Patches
Users should upgrade to
v5.18.0, orv6.0.0-alpha.2, in order to mitigate this vulnerability. Versions prior to v5 are likely to be affected, users are recommended to upgrade to a supportedgo-gitversion.The patched versions add support for configuring followRedirects. In line with upstream behaviour, the default is now
initial, while users can opt intoFollowRedirectsorNoFollowRedirectsprogrammatically.Credit
Thanks to the 3 separate reports from @celinke97, @N0zoM1z0 and @AyushParkara. Thanks for finding and reporting this issue privately to the
go-gitproject. 🙇Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:N/A:NRelease Notes
go-git/go-git (github.com/go-git/go-git/v5)
v5.18.0Compare Source
What's Changed
Full Changelog: go-git/go-git@v5.17.2...v5.18.0
v5.17.2Compare Source
What's Changed
v5.17.1. Thanks @pskrbasu for reporting it. 🙇Full Changelog: go-git/go-git@v5.17.1...v5.17.2
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.