Repository navigation
Conversation
…-protocol#798) The tour re-appeared in incognito and cross-tab sessions because the only persisted state was the step-progress record. Persist a has_completed_onboarding_v1 flag when the tour is finished or skipped and check it on page mount so the tour is never re-shown. Also make clearOnboardingState drop the in-memory fallback copy so "Restart Tour" clears the flag too.
Jaydbrown
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The onboarding tour displays repeatedly in certain incognito or cross-tab sessions, annoying experienced users.
Approach
Persist the
has_completed_onboarding_v1flag in localStorage and check it on page mount, per the issue's suggested approach.lib/onboarding-storage.tshasCompletedOnboarding()/markOnboardingCompleted()backed by thehas_completed_onboarding_v1key, using the module's existing safe (memory-fallback) accessors.clearOnboardingState()now also removes the completed flag, so Restart Tour in settings works.safeRemoveto always drop the in-memory fallback copy — previously a cleared key could linger in memory and still read as present (this was a pre-existing failing test:clearOnboardingState > allows the tour to run again after clearing).components/OnboardingTour.tsxTests
components/OnboardingTour.test.tsx(flag gates rendering; flag written on Finish/Skip/Escape; not written on intermediate Next) andlib/onboarding-storage.test.ts(flag read/write/clear, memory fallback).main(the 25 files already failing onmain, includingapp/dashboard/page.tsxtype errors, are unchanged).Closes #798