Add JevAgent for server-side decisions - #511
Open
NicholasDCole wants to merge 7 commits into
Open
NicholasDCole wants to merge 7 commits into
NicholasDCole wants to merge 7 commits into
Conversation
NicholasDCole
changed the title
NicholasDCole
changed the title
NicholasDCole
changed the title
NicholasDCole
marked this pull request as ready for review
September 25, 2026 20:30
propp-orkes
requested changes
Sep 28, 2026
| status=status.status, | ||
| finish_reason=self._runtime._derive_finish_reason(status.status, status.output), | ||
| error=status.reason if status.status in ("FAILED", "TERMINATED") else None, | ||
| error=status.reason if status.status in ("FAILED", "TERMINATED", "TIMED_OUT") else None, |
There was a problem hiding this comment.
Including TIMED_OUT here fixes only AgentHandle.join(). runtime.run()/run_async(), _run_with_events()/async, and _build_result_from_workflow() still set error=None for timed-out executions, so the documented result.error contract remains broken on those supported paths. Apply the same timeout handling everywhere an AgentResult is built and add coverage for each path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
JevAgent