Skip to content

fix(agents): name tool calls from the payload, and populate AgentResult.Events #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambiorix2099 merged 3 commits into from
Sep 22, 2026
Merged

fix(agents): name tool calls from the payload, and populate AgentResult.Events #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8c14dd
fix(agents): name tool calls from the payload, and populate AgentResu…
ambiorix2099 Aug 29, 2026
3571c1f
docs(agents): trim tool-extraction comments to the file's convention
ambiorix2099 Aug 29, 2026
c9b0da1
fix(agents): report a dispatched tool call that recorded no output
ambiorix2099 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 7 additions & 33 deletions Conductor.AI.Tests/AgentStatusMappingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,43 +26,16 @@ namespace Conductor.AI.Tests;

public sealed class AgentStatusMappingTests
{
private sealed class StubHandler : HttpMessageHandler
{
private readonly Func<HttpRequestMessage, (HttpStatusCode Status, string Body)> _respond;
public StubHandler(Func<HttpRequestMessage, (HttpStatusCode, string)> respond) => _respond = respond;

protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken ct)
{
var (status, body) = _respond(request);
return Task.FromResult(new HttpResponseMessage(status)
{
Content = new StringContent(body, Encoding.UTF8, "application/json"),
});
}
}

private static Configuration BuildConfig(Func<HttpRequestMessage, (HttpStatusCode, string)> respond)
{
var configuration = new Configuration { BasePath = "http://server/api" };
configuration.ApiClient.RestClient = new RestClient(new RestClientOptions("http://server/api")
{
ConfigureMessageHandler = _ => new StubHandler(respond),
});
return configuration;
}
=> StubAgentServer.Configure(respond);

private static (HttpStatusCode, string) RouteStatusAndExecution(
HttpRequestMessage request, string statusBody, string executionBody = "{}")
=> Route(request, statusBody, executionBody, "{}");

private static (HttpStatusCode, string) Route(
HttpRequestMessage request, string statusBody, string executionBody, string workflowBody)
{
var path = request.RequestUri!.AbsolutePath;
if (path.EndsWith("/status")) return (HttpStatusCode.OK, statusBody);
if (path.Contains("/execution/")) return (HttpStatusCode.OK, executionBody);
return (HttpStatusCode.OK, workflowBody);
}
=> StubAgentServer.Route(request, statusBody, executionBody, workflowBody);

// ── AgentRuntime.GetStatusAsync ──────────────────────────────────────

Expand Down Expand Up @@ -171,11 +144,12 @@ public async Task WaitAsync_ExtractsToolCallsFromWorkflowTasks()
executionBody: "{}",
workflowBody: """
{"tasks":[
{"taskType":"echo","referenceTaskName":"call_echo_1",
"inputData":{"query":"hello","_internal":"drop me","ctx":"drop me too"},
{"taskType":"echo","taskDefName":"echo","referenceTaskName":"call_ceOwlp7lQ_0__1",
"inputData":{"query":"hello","method":"echo","_agent_tool_name":"echo",
"_agent_state":{},"_internal":"drop me","ctx":"drop me too"},
"outputData":{"result":"echoed: hello"}},
{"taskType":"LLM_CHAT_COMPLETE","referenceTaskName":"llm_1",
"inputData":{},"outputData":{"promptTokens":10}}
{"taskType":"LLM_CHAT_COMPLETE","taskDefName":"llm_chat_complete",
"referenceTaskName":"llm_1","inputData":{},"outputData":{"promptTokens":10}}
]}
"""));

Expand Down
Loading
Loading