Fix CWE-426 (Untrusted Search Path) in example NSIS template - #1341
Open
michalwyszynski93 wants to merge 2 commits into
Open
Fix CWE-426 (Untrusted Search Path) in example NSIS template#1341michalwyszynski93 wants to merge 2 commits into
michalwyszynski93 wants to merge 2 commits into
Conversation
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @michalwyszynski93. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1439), and ping the bot to refresh the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mitigating CWE-426 vulnerability in the example NSIS template by using a fully qualified path instead of naked
cmd.exe.Many dev teams build up on this example for their custom installers. This propagates the vulnerability downstream to other projects.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?