Skip to content

Only warn when attempting to install an AMD64 EXE installer on ARM64 #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoesters merged 2 commits into from
Aug 27, 2026
+44 −8
Merged

Only warn when attempting to install an AMD64 EXE installer on ARM64 #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
141a070
Only warn when running a Windows ARM64 installer on AMD64
marcoesters Aug 27, 2026
eef6622
Add news file
marcoesters Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions constructor/nsis/main.nsi.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,22 +658,39 @@ Function .onInit
# on whether it's a 32-bit or 64-bit installer
SetRegView {{ BITS }}
{%- if win64 %}
# Make sure we're not on 32-bit or native ARM64 Windows (the latter would
# otherwise silently run this x64 installer under x64 emulation).
${IfNot} ${IsNativeAMD64}
${If} ${IsNativeARM64}
# Warn if not running on AMD64, but do not abort since ARM64 can still run
# AMD64 programs with emulation.
${Print} "This installer is for the 64-bit AMD (x86_64) version of ${NAME} \
but your system is ARM64. It is recommended to use an installer \
that matches your system's architecture."
MessageBox MB_OKCANCEL|MB_ICONEXCLAMATION \
"This installer is for the 64-bit AMD (x86_64) version of ${NAME} \
but your system is ARM64. It is recommended to use an installer \
that matches your system's architecture." \
/SD IDOK IDOK +2
Abort
${ElseIfNot} ${RunningX64}
# If we're a 64-bit installer, make sure it's 64-bit Windows
${Print} "::error:: This installer is for a 64-bit version for ${NAME} \
but your system is 32-bit. Please use the 32-bit Windows \
${NAME} installer."
MessageBox MB_OK|MB_ICONEXCLAMATION \
"This installer is for the 64-bit (x86_64) version of ${NAME}$\n\
but your system is not x86_64. Please use the installer that$\n\
matches your system's architecture." \
"This installer is for a 64-bit version for ${NAME} \
but your system is 32-bit. Please use the 32-bit Windows \
${NAME} installer." \
/SD IDOK
Abort
${EndIf}
{%- elif win_arm64 %}
# Make sure we're actually on native ARM64 Windows.
${IfNot} ${IsNativeARM64}
${Print} "::error::This installer is for the ARM64 version of ${NAME} \
but your system is not ARM64. Please use the installer that \
matches your system's architecture."
MessageBox MB_OK|MB_ICONEXCLAMATION \
"This installer is for the ARM64 version of ${NAME}$\n\
but your system is not ARM64. Please use the installer that$\n\
"This installer is for the ARM64 version of ${NAME} \
but your system is not ARM64. Please use the installer that \
matches your system's architecture." \
/SD IDOK
Abort
Expand Down
19 changes: 19 additions & 0 deletions news/1337-windows-arch-check-warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* EXE installers: only warn when attempting to install a Windows AMD64 installer on ARM64. (#1337)

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
Loading