Repository navigation
fix: do not discard unread member data on empty buffer reads (#478) - #495
Open
slopgobblercobbler wants to merge 1 commit into
Open
slopgobblercobbler wants to merge 1 commit into
slopgobblercobbler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #478.
When calling
readon anEntrywith an empty buffer (&mut []),EntryFields::readmatchesSome(Ok(0))from the underlyingEntryIoand removesself.data[0], treating zero bytes read as EOF. This discards unread member bytes for subsequent reads.Per
std::io::Read, reading into a zero-length slice should returnOk(0)immediately without advancing or consuming data. ReturningOk(0)wheninto.is_empty()keeps the currentEntryIoentry intact.Testing
Added
empty_buffer_read_does_not_discard_dataintests/all.rs:All 74 tests in
tests/all.rspass.