Repository navigation
fix(pax): reject empty keys or keys containing '=' in append_pax_extensions (#486) - #494
Open
slopgobblercobbler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
Builder::append_pax_extensions, keys containing=or empty keys are accepted without error. When the archive is parsed back, the reader splits on the first=(pax.rs:109), resulting in split corruption where the key is truncated at the first=and the remainder becomes part of the value. For example,("a=b", b"c")reads back askey: "a", value: "b=c", and("=", b"")reads back askey: "", value: "=".According to the POSIX PAX specification (IEEE Std 1003.1), extended header keywords must not contain
=and cannot be empty.Solution
In
Builder::append_pax_extensions(src/pax.rs), validate each key before formatting:=Added unit test
pax_invalid_keys_rejectedintests/all.rscovering these failure paths and ensuring valid keys continue to serialize cleanly.Fixes #486