Repository navigation
builder: Reject .. in long paths past the 100-byte mark - #489
Open
darshan-mog wants to merge 1 commit into
Open
darshan-mog wants to merge 1 commit into
darshan-mog wants to merge 1 commit into
Conversation
Header::set_path refuses `..` components, but once a path is 100 bytes or longer prepare_header_path falls back to a GNU long name and only the truncated prefix stored in the header gets validated. A `..` after that point was written into the long name unchecked, so "c" * 100 + "/../../evil" was accepted while "a/../evil" was not. Check the full path before emitting the long-name entry. Assisted-by: AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare_header_pathonly validates the first 100 bytes when it falls back to a GNU long name, soappend_dataaccepts"c".repeat(100) + "/../../evil"and writes the..into the archive even thougha/../evilis refused; reject..in the full path before emitting the long-name entry.