Skip to content

Make package-dump work on other platforms#35

Open
finestructure wants to merge 1 commit intocompnerd:mainfrom
finestructure:main
Open

Make package-dump work on other platforms#35
finestructure wants to merge 1 commit intocompnerd:mainfrom
finestructure:main

Conversation

@finestructure
Copy link
Copy Markdown

This package is currently failing version discovery on the Swift Package Index, because swift package dump-package fails on Linux (where we run package checks):

/Users/sas/Projects/SPI/spi-server/SPI-checkouts/github.com-compnerd-swift-firebase/Package.swift:5:8: error: no such module 'WinSDK'
  3 | import PackageDescription
  4 | import Foundation
  5 | import WinSDK
    |        `- error: no such module 'WinSDK'
  6 |
  7 | let swiftc = "swiftc.exe".withCString(encodedAs: UTF16.self) { pwszCompiler in
error: invalid manifests at [<AbsolutePath:"/Users/sas/Projects/SPI/spi-server/SPI-checkouts/github.com-compnerd-swift-firebase">]

I'm not sure if the proposed way is the best way to fix it or if you're even interested in fixing it but I wanted to at least propose a solution.

Failing version discovery on the Swift Package Index means that we don't discover and show new releases on the package page.

@finestructure
Copy link
Copy Markdown
Author

The package listing is here: https://swiftpackageindex.com/compnerd/swift-firebase

@compnerd
Copy link
Copy Markdown
Owner

Do we need an additional path for finding the include path for libdispatch? I'd rather have the package build on other platforms as well, it isn't Windows specific, this is just a limitation of SPM.

@finestructure
Copy link
Copy Markdown
Author

I'm afraid I can't answer that - I just tried the minimal changes to make dump-package work on Linux/macOS 😅

@compnerd
Copy link
Copy Markdown
Owner

macOS doesn't require the flags, I'm not sure about Linux. I think we can simply conditionalize the flags for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants