Make package-dump work on other platforms#35
Open
finestructure wants to merge 1 commit intocompnerd:mainfrom
Open
Make package-dump work on other platforms#35finestructure wants to merge 1 commit intocompnerd:mainfrom
finestructure wants to merge 1 commit intocompnerd:mainfrom
Conversation
Author
|
The package listing is here: https://swiftpackageindex.com/compnerd/swift-firebase |
Owner
|
Do we need an additional path for finding the include path for libdispatch? I'd rather have the package build on other platforms as well, it isn't Windows specific, this is just a limitation of SPM. |
Author
|
I'm afraid I can't answer that - I just tried the minimal changes to make dump-package work on Linux/macOS 😅 |
Owner
|
macOS doesn't require the flags, I'm not sure about Linux. I think we can simply conditionalize the flags for Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is currently failing version discovery on the Swift Package Index, because
swift package dump-packagefails on Linux (where we run package checks):I'm not sure if the proposed way is the best way to fix it or if you're even interested in fixing it but I wanted to at least propose a solution.
Failing version discovery on the Swift Package Index means that we don't discover and show new releases on the package page.