Repository navigation
feat(agentconfig): config model and RFC 7396 overlay merge (1/15) - #469
Merged
Merged
Conversation
First layer of the agent remote-configuration stack (split from #465): the declared agent config types, JSON helpers and canonical encoding, RFC 6901 pointers, and Merge/MergePatch/StripLocked of an API overlay onto the agent's file config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gusfcarvalho
changed the title
gusfcarvalho
added this pull request to stack #484
October 5, 2026 17:30
This was referenced Oct 5, 2026
Merged
This was referenced Oct 6, 2026
…ined Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
decodeAny and decodeConfig decoded through a json.Decoder, which copies its input through a buffer it grows by doubling: about 4 MiB of allocations per decode of a 1 MiB document, and a config save decodes a reported base about six times. Decode with json.Unmarshal instead, which reads the bytes in place, keeping the Decoder's results exactly: - decodeAny decodes into numberValue, which builds the same map[string]any, []any and json.Number values as a UseNumber Decoder. Documents nested deeper than 12 levels (Unmarshal re-scans each level) and input Unmarshal rejects still go through the Decoder, so its errors are unchanged. - decodeConfig unmarshals the struct and takes policy_data, the one free-form field, from the UseNumber decoding it already has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1/15 of the agent remote-configuration stack
This stack splits #465 into reviewable layers of at most ~1000 changed lines each (counted without
docs/,go.sumand Markdown). The last layer's tree is identical to #465, which already has its review history.Base of the stack (targets
main). Review and merge in order.What's in this layer
First layer of the agent remote-configuration stack (split from #465): the declared agent config types, JSON helpers and canonical encoding, RFC 6901 pointers, and Merge/MergePatch/StripLocked of an API overlay onto the agent's file config.
Size: +1056 -0 = 1056 changed lines (without docs/go.sum).
Verification
Each layer builds on its own:
go build,go vet(also with-tags integration),golangci-lint runandgo test ./...pass, andmake swagleaves the tree clean. Integration suites for the packages this layer touches pass locally on testcontainers Postgres.🤖 Generated with Claude Code