Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Behavior changes:

Other enhancements:

* Consider Cabal 3.18 to be a tested library and remove warnings.

Bug fixes:

## v4.1.1
Expand Down
4 changes: 2 additions & 2 deletions src/Stack/Setup.hs
Original file line number Diff line number Diff line change
Expand Up @@ -1095,9 +1095,9 @@ warnUnsupportedCompilerCabal cp didWarn = do
, parens (style Shell "nightly-2018-03-13")
, flow "or later specify such GHC versions."
]
| cabalVersion >= mkVersion [3, 17] && notifyIfCabalUntested ->
| cabalVersion >= mkVersion [3, 19] && notifyIfCabalUntested ->
prettyWarnL
[ flow "Stack has not been tested with Cabal versions 3.18 and \
[ flow "Stack has not been tested with Cabal versions 3.20 and \
\above, but version"
, fromString (versionString cabalVersion)
, flow "was found, this may fail."
Expand Down
12 changes: 11 additions & 1 deletion src/setup-shim/StackSetupShim.hs
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ import Distribution.Types.PackageDescription ( PackageDescription )
import Distribution.Utils.Path
( interpretSymbolicPathCWD, makeSymbolicPath, relativeSymbolicPath )
#endif
#if MIN_VERSION_Cabal(3,18,0)
import Distribution.Verbosity ( Verbosity (..), defaultVerbosityHandles )
#else
import Distribution.Verbosity ( Verbosity )
#endif
#endif
import Distribution.Verbosity ( flagToVerbosity )
import Main
import System.Environment ( getArgs )
Expand Down Expand Up @@ -88,7 +92,13 @@ stackReplHook arg1 arg2 = do
"Unexpected happened running Setup.hs with " <>
"stack-initial-build-steps, expected to parse Cabal verbosity: " <>
msg1
Right verbosity -> do
Right verbosityFlags -> do
let verbosity =
#if MIN_VERSION_Cabal(3,18,0)
Verbosity verbosityFlags defaultVerbosityHandles
#else
verbosityFlags
#endif
eFp <-
#if MIN_VERSION_Cabal(3,14,0)
findPackageDesc Nothing
Expand Down
Loading