Repository navigation
Fixes #249: Update BR-SC.json with new subdivisions - #250
Open
emersonreisdev wants to merge 4 commits into
Open
emersonreisdev wants to merge 4 commits into
emersonreisdev wants to merge 4 commits into
Conversation
emersonreisdev
marked this pull request as ready for review
September 17, 2026 22:49
emersonreisdev
changed the title
Contributor
|
Thanks for the MR! We should be replacing the old versions. It's confusing to have duplicates, and the data model ensures that the old versions are rendered as-is, so the only problem is users having to reselect on edit, which is a rarer operation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://servicodados.ibge.gov.br/api/v1/localidades/estados/SC/municipios which is the official list of cities.
Some have changed their spelling, and Piçarras is now Balneário Piçarras.
I propose keeping the old version on the list to allow consumers to migrate from the old one to the new one.
Fixes #249