Repository navigation
Update subdivisions for Guatemala (GT) - #242
Merged
Merged
Conversation
Contributor
|
Thanks! This also requires address format changes to ensure that an administrative area (department) field is shown for GT. Pushed a fix for that: 6bcaa06 Your PR still needs a bit of work. You should not be defining any codes. The entries should be alphabetical. And you need to verify the ISO codes you are keying by. Also, make sure your JSON file uses tabs and not spaces. |
Contributor
Author
|
Thanks, fixed as suggested. |
Contributor
|
Is there a reason why you're using pre-2021 ISO codes here? Cause on 2021-11-25 ISO switched to numeric codes for GT (GT-AV -> GT-16, GT-CM -> GT-04, etc), so I'm wondering whether your source is out of date or if this is intentional. |
Contributor
Author
|
Absolutely right. The source was outdated. Thanks |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added subdivisions for Guatemala's 22 departments