Skip to content

Update subdivisions for Guatemala (GT) - #242

Merged
bojanz merged 3 commits into
commerceguys:mainfrom
jgalindosl:main
Aug 22, 2026
Merged

bojanz merged 3 commits into
commerceguys:mainfrom
jgalindosl:main

Conversation

@jgalindosl

Copy link
Copy Markdown
Contributor

Added subdivisions for Guatemala's 22 departments

@bojanz

bojanz commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Thanks!

This also requires address format changes to ensure that an administrative area (department) field is shown for GT. Pushed a fix for that: 6bcaa06

Your PR still needs a bit of work. You should not be defining any codes. The entries should be alphabetical. And you need to verify the ISO codes you are keying by. Also, make sure your JSON file uses tabs and not spaces.

@jgalindosl

Copy link
Copy Markdown
Contributor Author

Thanks, fixed as suggested.

@bojanz

bojanz commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Is there a reason why you're using pre-2021 ISO codes here?

Cause on 2021-11-25 ISO switched to numeric codes for GT (GT-AV -> GT-16, GT-CM -> GT-04, etc), so I'm wondering whether your source is out of date or if this is intentional.

@jgalindosl

Copy link
Copy Markdown
Contributor Author

Absolutely right. The source was outdated. Thanks

@bojanz
bojanz merged commit 5155099 into commerceguys:main Aug 22, 2026
4 of 5 checks passed
@bojanz

bojanz commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants