Skip to content

feat: implement issue #505 — SonarCloud: shell script hygiene #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 6 commits into from
Oct 15, 2026
+8 −8
Merged

feat: implement issue #505 — SonarCloud: shell script hygiene #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71a4287
feat: implement issue #505 — SonarCloud: shell script hygiene
don-petry Oct 13, 2026
c7b3288
Merge branch 'main' into dev-lead/issue-505-20261013-2155
don-petry Oct 14, 2026
6d97108
Merge branch 'main' into dev-lead/issue-505-20261013-2155
don-petry Oct 14, 2026
6b86816
Merge branch 'main' into dev-lead/issue-505-20261013-2155
don-petry Oct 14, 2026
c46b4eb
Merge branch 'main' into dev-lead/issue-505-20261013-2155
don-petry Oct 14, 2026
9c14a28
Merge branch 'main' into dev-lead/issue-505-20261013-2155
don-petry Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/scripts/apply-code-quality-ruleset.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ set -euo pipefail
REPO="combsmith/markets"
RULESET_NAME="code-quality"

if [ -z "${GH_TOKEN:-}" ]; then
if [[ -z "${GH_TOKEN:-}" ]]; then
echo "ERROR: GH_TOKEN is required with administration:write scope" >&2
exit 1
fi
Expand All @@ -52,7 +52,7 @@ REQUIRED_BYPASS_ACTORS=$(jq -n \

# When updating an existing ruleset, fetch its current bypass actors and merge them
# with the required actors so that other legitimate bypass actors are not silently removed.
if [ -n "$EXISTING_ID" ]; then
if [[ -n "$EXISTING_ID" ]]; then
EXISTING_BYPASS=$(gh api "repos/$REPO/rulesets/$EXISTING_ID" \
--jq '.bypass_actors // []' 2>/dev/null || echo "[]")
BYPASS_ACTORS=$(echo "$EXISTING_BYPASS" | \
Expand Down Expand Up @@ -92,7 +92,7 @@ PAYLOAD=$(jq -n --argjson bypass_actors "$BYPASS_ACTORS" '{
bypass_actors: $bypass_actors
}')

if [ -n "$EXISTING_ID" ]; then
if [[ -n "$EXISTING_ID" ]]; then
echo "Updating existing $RULESET_NAME ruleset (id=$EXISTING_ID) ..."
echo "$PAYLOAD" | gh api -X PUT "repos/$REPO/rulesets/$EXISTING_ID" --input - > /dev/null
echo "Done — ruleset updated: https://github.com/$REPO/rules/$EXISTING_ID"
Expand Down
4 changes: 2 additions & 2 deletions .github/scripts/apply-pr-quality-ruleset.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ set -euo pipefail
REPO="combsmith/markets"
RULESET_NAME="pr-quality"

if [ -z "${GH_TOKEN:-}" ]; then
if [[ -z "${GH_TOKEN:-}" ]]; then
echo "ERROR: GH_TOKEN is required with administration:write scope" >&2
exit 1
fi
Expand Down Expand Up @@ -83,7 +83,7 @@ PAYLOAD=$(jq -n '{
]
}')

if [ -n "$EXISTING_ID" ]; then
if [[ -n "$EXISTING_ID" ]]; then
echo "Updating existing $RULESET_NAME ruleset (id=$EXISTING_ID) ..."
echo "$PAYLOAD" | gh api -X PUT "repos/$REPO/rulesets/$EXISTING_ID" --input - > /dev/null
echo "Done — ruleset updated: https://github.com/$REPO/rules/$EXISTING_ID"
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/apply-repo-settings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ set -euo pipefail
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
REPO="combsmith/markets"

if [ -z "${GH_TOKEN:-}" ]; then
if [[ -z "${GH_TOKEN:-}" ]]; then
echo "ERROR: GH_TOKEN is required with administration:write scope" >&2
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/apply-secret-scanning-ai-detection.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ set -euo pipefail

REPO="combsmith/markets"

if [ -z "${GH_TOKEN:-}" ]; then
if [[ -z "${GH_TOKEN:-}" ]]; then
echo "ERROR: GH_TOKEN is required with administration:write scope" >&2
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/apply-secret-scanning-non-provider-patterns.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ set -euo pipefail

REPO="combsmith/markets"

if [ -z "${GH_TOKEN:-}" ]; then
if [[ -z "${GH_TOKEN:-}" ]]; then
echo "ERROR: GH_TOKEN is required with administration:write scope" >&2
exit 1
fi
Expand Down
Loading