Skip to content

feat: implement issue #520 — agent-ingress pr-review job pins the legacy bare pr-review/stable (DEFECTIVE PIN): move both pin lines to pr-review/v1-stable #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 2 commits into from
Oct 10, 2026
Merged

feat: implement issue #520 — agent-ingress pr-review job pins the legacy bare pr-review/stable (DEFECTIVE PIN): move both pin lines to pr-review/v1-stable #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c781d3
feat: implement issue #520 — agent-ingress pr-review job pins the leg…
don-petry Oct 10, 2026
2a0eb93
fix(reviews): use regex match for v1-stable pin assertion
don-petry Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/scripts/tests/agent-ingress-workflow.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ ROLES=(dev-lead pr-auto-review pr-review pr-review-mention ci-failure-analyst)
[[ "$output" == *"/pr-auto-review-reusable.yml@pr-auto-review/v1-stable" ]]
run yq '.jobs.pr-review.uses' "$WORKFLOW"
[ "$status" -eq 0 ]
[[ "$output" == *"/pr-review.yml@pr-review/stable" ]]
[[ "$output" == *"/pr-review.yml@pr-review/v1-stable" ]]
run yq '.jobs.pr-review.with.agent_ref' "$WORKFLOW"
[ "$status" -eq 0 ]
[ "$output" = "pr-review/stable" ]
[ "$output" = "pr-review/v1-stable" ]
run yq '.jobs.pr-review-mention.uses' "$WORKFLOW"
[ "$status" -eq 0 ]
[[ "$output" == *"/pr-review-mention-reusable.yml@pr-review-mention/v2-stable" ]]
Expand Down Expand Up @@ -161,3 +161,10 @@ ROLES=(dev-lead pr-auto-review pr-review pr-review-mention ci-failure-analyst)
|| { printf '%s\n' "$role: if: reaches repo state"; return 1; }
done
}

@test "pr-review pins the major-scoped v1-stable channel, not the legacy bare tag (#520)" {
run grep -E '/pr-review\.yml@' "$WORKFLOW"
[ "$status" -eq 0 ]
[[ "$output" =~ @pr-review/v1-stable[[:space:]]+#[[:space:]]*NOSONAR\(githubactions:S7637\)[[:space:]]+first-party[[:space:]]+channel[[:space:]]+ref ]]
[[ "$output" != *"DEFECTIVE PIN"* ]]
}
4 changes: 2 additions & 2 deletions .github/workflows/agent-ingress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ jobs:
contents: read
pull-requests: write
checks: read
uses: petry-projects/.github-private/.github/workflows/pr-review.yml@pr-review/stable # NOSONAR(githubactions:S7637) first-party channel ref # DEFECTIVE PIN — see §5
uses: petry-projects/.github-private/.github/workflows/pr-review.yml@pr-review/v1-stable # NOSONAR(githubactions:S7637) first-party channel ref
with:
agent_ref: pr-review/stable
agent_ref: pr-review/v1-stable
pr_url: ${{ inputs.pr_url || '' }}
dry_run: ${{ inputs.dry_run || '' }}
force_review: ${{ inputs.force_review || '' }}
Expand Down
Loading