Skip to content

dev-lead: deferred review findings #519

Closed as not planned
Closed as not planned

Description

@don-petry

Tracking issue for valid review findings deferred out of scope of their PRs.

Activity

  1. don-petry commented on Oct 9, 2026

    @don-petry
    ContributorAuthor

    Deferred from PR #502: #502 (comment) — pr-auto-review.yml concurrency groups multi-PR check_suite/workflow_run completions under pull_requests[0], so cancel-in-progress could suppress readiness evaluation for another associated PR. The block is a verbatim sync of the canonical standards/workflows/pr-auto-review.yml; any change belongs upstream in petry-projects/.github.

  2. don-petry commented on Oct 10, 2026

    @don-petry
    ContributorAuthor

    Deferred from PR #517 thread PRRT_kwDORntvTc6q_jPu (#517 (comment)): rate-limit gate counts runs of the caller workflow (incl. deferred ones) rather than accepted central-driver dispatches; needs a dispatch-recording/query contract change in petry-projects/.github's agent-rate-limit-gate.sh.

  3. don-petry commented on Oct 11, 2026

    @don-petry
    ContributorAuthor

    From PR #517: Rate-limit gate counts workflow attempts, not successful dispatches. The daily budget fills with deferred runs, causing the gate to keep deferring work even when below the dispatch limit. Requires changes to the gate script in petry-projects/.github to track dispatches separately.

    Thread: #517 (comment)

  4. don-petry commented on Oct 21, 2026

    @don-petry
    ContributorAuthor

    Closing after the 2026-10-21 backlog triage.

    Why: Items duplicate .github#1327 and by-design .github#1126
    Evidence: combsmith/.github#1327

    Reopen if this still reproduces on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions