Compliance: missing-code-quality #51

Activity

1. don-petry

   added

   compliance-auditAutomated compliance audit findingAutomated compliance audit finding

   claude

   on Apr 5, 2026
2. claude commented on Apr 5, 2026

   

   claudeBot

   on Apr 5, 2026 – with Claude

   More actions

   Claude Code is working…

   I'll analyze this and get back to you.

   View job run
3. don-petry commented on Apr 6, 2026

   

   don-petry

   on Apr 6, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-04-06)

   This finding is still open.

   Detail: Missing code-quality repository ruleset (required status checks)

   Standard: standards/github-settings.md#code-quality--required-checks-ruleset-all-repositories
4. don-petry commented on Apr 6, 2026

   

   don-petry

   on Apr 6, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-04-06)

   This finding is still open.

   Detail: Missing code-quality repository ruleset (required status checks)

   Standard: standards/github-settings.md#code-quality--required-checks-ruleset-all-repositories
5. don-petry commented on Apr 6, 2026

   

   don-petry

   on Apr 6, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-04-06)

   This finding is still open.

   Detail: Missing code-quality repository ruleset (required status checks)

   Standard: standards/github-settings.md#code-quality--required-checks-ruleset-all-repositories
6. don-petry commented on Apr 6, 2026

   

   don-petry

   on Apr 6, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-04-06)

   This finding is still open.

   Detail: Missing code-quality repository ruleset (required status checks)

   Standard: standards/github-settings.md#code-quality--required-checks-ruleset-all-repositories
7. don-petry commented on Apr 6, 2026

   

   don-petry

   on Apr 6, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-04-06)

   This finding is still open.

   Detail: Missing code-quality repository ruleset (required status checks)

   Standard: standards/github-settings.md#code-quality--required-checks-ruleset-all-repositories
8. don-petry

   added

   claude

   and removed

   claude

   on Apr 6, 2026
9. don-petry commented on Apr 6, 2026

   

   don-petry

   on Apr 6, 2026

   Last edited by don-petry

   ContributorAuthor

   More actions

   Claude encountered an error —— View job • claude/issue-51-20260406-1853 • [Create PR ➔](https://github.com/petry-projects/markets/compare/main...claude/issue-51-20260406-1853?quick_pull=1&title=Issue%20%2351%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%2351%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)

   ---

   Compliance Fix: Missing code-quality Ruleset

   • Analyze issue and gather context
   • Read existing workflows to identify available status checks
   • Create .github/scripts/create-code-quality-ruleset.sh (idempotent setup script)
   • Commit and push script to branch
   • Create PR

   Note: Creating a repository ruleset requires administration write permission, which the Claude Code workflow token doesn't have. The script in this PR must be run by a repo admin with a token that has admin rights.
10. github-actions

    added a commit that references this issue on Apr 6, 2026

    feat: add script to create code-quality repository ruleset

    ...

    This issue will close once commit 764c1d3 is merged into the 'main' branch.

    764c1d3
11. don-petry

    added a commit that references this issue on Apr 7, 2026

    feat: add script to create code-quality repository ruleset

    ...

    This issue will close once commit 26de4af is merged into the 'main' branch.

    26de4af
12. don-petry

    added

    claude

    and removed

    claude

    on Apr 7, 2026
13. don-petry commented on Apr 7, 2026

    

    don-petry

    on Apr 7, 2026

    Last edited by don-petry

    ContributorAuthor

    More actions

    Claude finished @don-petry's task in 4m 20s —— View job • claude/issue-51-20260407-0239 • Create PR ➔

    ---

    Compliance Fix: Missing code-quality Ruleset

    • Analyze issue and gather context
    • Review existing workflows and available status checks
    • Create idempotent setup script at .github/scripts/create-code-quality-ruleset.sh
    • Self-review: removed invalid API fields (integration_id: null, do_not_enforce_on_create)
    • Commit and push changes
    • Create PR → petry-projects/markets#67

    ---

    What was done

    Added .github/scripts/create-code-quality-ruleset.sh — an idempotent script that creates (or updates) the code-quality repository ruleset to satisfy the org compliance standard.

    Required status checks configured:

    Check	Source workflow
    Analyze	.github/workflows/codeql.yml
    SonarCloud	.github/workflows/sonarcloud.yml
    Detect ecosystems	.github/workflows/dependency-audit.yml

    Why a script? Creating a repository ruleset requires administration:write permission. A repo admin must run this once:

    export GH_TOKEN=<admin-token>
    bash .github/scripts/create-code-quality-ruleset.sh

    @don-petry — you're the CODEOWNERS owner for this repo. Please review and merge PR #67, then run the script with an admin token to complete the compliance fix.
    · Branch: claude/issue-51-20260407-0239
14. github-actions

    added a commit that references this issue on Apr 7, 2026

    fix: add idempotent script to create code-quality repository ruleset

    ...

    This issue will close once commit c79650d is merged into the 'main' branch.

    c79650d
15. don-petry

    added

    claude

    and removed

    claude

    on Apr 8, 2026
16. don-petry commented on Apr 8, 2026

    

    don-petry

    on Apr 8, 2026

    Last edited by don-petry

    ContributorAuthor

    More actions

    Claude finished @don-petry's task in 4m 24s —— View job • claude/issue-51-20260408-0149 • [Create PR ➔](https://github.com/petry-projects/markets/compare/main...claude/issue-51-20260408-0149?quick_pull=1&title=Issue%20%2351%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%2351%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)

    ---

    Compliance Fix: Missing code-quality Ruleset

    • Analyze issue and gather context
    • Read org standard for code-quality ruleset
    • Inspect actual CI check run names (to use correct context strings)
    • Create code-quality ruleset via GitHub API — now live (ruleset id 14805963)
    • Add .github/scripts/apply-code-quality-ruleset.sh for idempotent future maintenance
    • Commit and push
    • Create PR → petry-projects/markets#77
    • Self-review: script is correct; check names verified against actual CI runs
    • Tag CODEOWNER for review

    ---

    What was done

    The code-quality ruleset was created directly via the GitHub API and is already active — no admin script execution needed by a human this time. It enforces these required status checks on the default branch (main):

    Check	Context string	Source
    SonarCloud	SonarCloud	sonarcloud.yml, job sonarcloud
    CodeQL	Analyze (actions)	codeql.yml, matrix job (actions ecosystem)
    Claude Code	claude-code / claude	claude.yml → reusable workflow

    Settings: strict mode (branch must be up to date before merge).

    PR #77 adds .github/scripts/apply-code-quality-ruleset.sh — a repo-local idempotent script for future maintenance (in case the ruleset needs to be re-created or updated).
    · Branch: claude/issue-51-20260408-0149
17. don-petry

    added 2 commits that reference this issue on Apr 8, 2026

    fix: add code-quality ruleset maintenance script

    ...

    This issue will close once commit e9f5ddc is merged into the 'main' branch.

    e9f5ddc

    fix: add code-quality ruleset maintenance script

    ...

    This issue will close once commit 4943fa8 is merged into the 'main' branch.

    4943fa8
18. don-petry

    closed this as completedin #77on Apr 8, 2026
19. don-petry

    added a commit that references this issue on Jun 19, 2026

    fix: add code-quality repository ruleset (closes #51) (#77)

    ...

    This issue will close once commit d570126 is merged into the 'main' branch.

    d570126