Repository navigation
SonarCloud: shell script hygiene #505
Description
SonarCloud: shell script hygiene
8 open SonarCloud finding(s) in petry-projects/markets, worst severity MAJOR. Generated by the org SonarCloud Audit.
Findings
| Rule | Count | Representative message |
|---|---|---|
| shelldre:S7688 | 8 | Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more featur |
Affected files
.github/scripts/apply-code-quality-ruleset.sh(3).github/scripts/apply-pr-quality-ruleset.sh(2).github/scripts/apply-repo-settings.sh(1).github/scripts/apply-secret-scanning-ai-detection.sh(1).github/scripts/apply-secret-scanning-non-provider-patterns.sh(1)
Priority
Labeled priority:major — mapped from this bucket's worst SonarCloud severity (MAJOR).
Acceptance
- All findings in this workstream resolved to zero in SonarCloud
- No behavior change; CI green
- Real fixes (no blanket
NOSONARunless a confirmed false positive, noted inline)
Idempotent issue — updated automatically each audit run; auto-closed when the finding count reaches zero.
Activity
don-petry commentedon Oct 6, 2026
SonarCloud Audit (2026-10-06): still open — 8 finding(s), worst severity
MAJOR.don-petry commentedon Oct 6, 2026
Dev-Lead: implementation deferred — automation PR queue is full
No pull request was opened for issue #505. The org-wide
open-automation-PR queue is currently at its signed-off cap (see
standards/pr-limits.jsoninpetry-projects/.github).This issue stays labeled
dev-leadand will be re-attempted automatically oncethe queue drains — no action is required.
don-petry commentedon Oct 13, 2026
SonarCloud Audit (2026-10-13): still open — 8 finding(s), worst severity
MAJOR.don-petry commentedon Oct 13, 2026
Dev-Lead Implementation Plan
Issue: #505 — SonarCloud: shell script hygiene
Scope
Replace the 8 POSIX
[ ... ]conditional tests flagged by shelldre:S7688 with bash[[ ... ]]in the bash-shebanged.github/scripts/apply-*.shscripts. No behavior change.Implementation Checklist
.github/scripts/apply-code-quality-ruleset.sh(lines 34, 55, 95).github/scripts/apply-pr-quality-ruleset.sh(lines 39, 86).github/scripts/apply-repo-settings.sh(line 18).github/scripts/apply-secret-scanning-ai-detection.sh(line 25).github/scripts/apply-secret-scanning-non-provider-patterns.sh(line 25)Tests to Write
-z/-nsemantics identical under[[). Verified viabash -n, shellcheck, and a grep confirming no remaining single-bracket tests.Test Command
bash -n <script>,shellcheck .github/scripts/apply-*.sh,bash .dev-lead/scripts/dev-lead-lint.shdon-petry commentedon Oct 13, 2026
Dev-Lead: Implementation Complete — PR #527
The implementation for issue #505 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.
71a4287d803f6d69850d221358bfe7d7f5ab4888main: 5 file(s), +8/-8 linesReview happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.
feat: implement issue #505 — SonarCloud: shell script hygiene (#527)