Compliance: stub-surface-drift-pr-auto-review.yml-concurrency #501

Activity

1. don-petry

   added

   compliance-auditAutomated compliance audit findingAutomated compliance audit finding

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   compliance-findingMachine-owned: created and auto-closed by the compliance audit. Do not hand-apply.Machine-owned: created and auto-closed by the compliance audit. Do not hand-apply.

   on Sep 25, 2026
2. don-petry commented on Sep 25, 2026

   

   don-petry

   on Sep 25, 2026

   ContributorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #501 — Compliance: stub-surface-drift-pr-auto-review.yml-concurrency

   Scope

   Re-sync the centrally-owned concurrency: surface of .github/workflows/pr-auto-review.yml verbatim from the canonical standards/workflows/pr-auto-review.yml, leaving the repo-adjustable surfaces (the workflow_run.workflows: ["CI"] name and its repo-specific comment, the with:/secrets: block, and the channel pin) untouched.

   Drift identified

   The local stub's concurrency: block keys off pull_request / pull_request_review PR context, while canonical keys off check_suite / workflow_run default-branch context (issue #1126 rework). The explanatory comment documenting the block has drifted correspondingly.

   Implementation Checklist

   • Replace the concurrency: block (and its documenting comment) in .github/workflows/pr-auto-review.yml with the canonical version, byte-for-byte
   • Confirm on: triggers, permissions:, job permissions:, uses: channel pin, and secrets: are unchanged
   • Confirm workflow_run.workflows: ["CI"] repo-specific value/comment is preserved

   Tests to Write

   • Phase 2 exception: this is a pure CI-workflow configuration sync. There is no unit-test harness for workflow YAML in this repo (the lint script covers shellcheck + agent frontmatter only; drift detection is fleet-level). Verification is by diffing the resynced concurrency: block against canonical for byte-identity.

   Test Command

   bash .dev-lead/scripts/dev-lead-lint.sh (repo lint gate); byte-diff of the concurrency: block vs canonical
3. don-petry commented on Sep 25, 2026

   

   don-petry

   on Sep 25, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Implementation Complete — PR #502

   The implementation for issue #501 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

   • Pull request: feat: implement issue #501 — Compliance: stub-surface-drift-pr-auto-review.yml-concurrency #502
   • Head commit: 9191a5d1d2dd19f7d4299457e0ca3a10a2637129
   • Net change against main: 1 file(s), +17/-13 lines
   • Run: https://github.com/petry-projects/markets/actions/runs/36169683892

   Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.
4. don-petry commented on Oct 2, 2026

   

   don-petry

   on Oct 2, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-10-02)

   This finding is still open.

   Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

   Standard: standards/ci-standards.md#centralization-tiers
5. don-petry commented on Oct 9, 2026

   

   don-petry

   on Oct 9, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-10-09)

   This finding is still open.

   Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

   Standard: standards/ci-standards.md#centralization-tiers
6. don-petry commented on Oct 10, 2026

   

   don-petry

   on Oct 10, 2026 – with Claude

   ContributorAuthor

   More actions

   Closing as not planned. The pr-auto-review.yml stub this finding is about was deleted by #513 (ADR-0007 collapse). Its concurrency now lives in the pr-auto-review job of .github/workflows/agent-ingress.yml, so there is nothing left to re-sync. Do not re-create the stub. The compliance audit's awareness of collapsed stubs is tracked under combsmith/.github-private#1729 (AC11).

   ---

   Generated by Claude Code
7. don-petry

   closed this as not plannedon Oct 10, 2026