Skip to content

Compliance: required-claude-check-broken #97

Closed

Description

@don-petry

Compliance Finding

Category: rulesets
Severity: error
Check: required-claude-check-broken

Detail

Required-status-check ruleset includes claude, which is incompatible with workflow-modifying PRs. claude-code-action's GitHub App refuses to mint an OAuth token for any PR whose diff includes a workflow file, so the check fails on every workflow PR and the merge gate becomes a deadlock. Remove claude from required status checks — do NOT rename it. The Claude review check still runs on normal PRs and surfaces feedback without being a merge gate. See scripts/apply-rulesets.sh (post combsmith/.github#94) for the canonical required-checks list.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Apr 9, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-04-09)

    This finding is still open.

    Detail: Required-status-check ruleset includes claude, which is incompatible with workflow-modifying PRs. claude-code-action's GitHub App refuses to mint an OAuth token for any PR whose diff includes a workflow file, so the check fails on every workflow PR and the merge gate becomes a deadlock. Remove claude from required status checks — do NOT rename it. The Claude review check still runs on normal PRs and surfaces feedback without being a merge gate. See scripts/apply-rulesets.sh (post combsmith/.github#94) for the canonical required-checks list.

    Standard: standards/ci-standards.md#centralization-tiers

  2. don-petry commented on Apr 9, 2026

    @don-petry
    ContributorAuthor

    Claude encountered an error —— View job


    I'll analyze this and get back to you.

  3. don-petry commented on Apr 10, 2026

    @don-petry
    ContributorAuthor

    Weekly Compliance Audit (2026-04-10)

    This finding is still open.

    Detail: Required-status-check ruleset includes claude, which is incompatible with workflow-modifying PRs. claude-code-action's GitHub App refuses to mint an OAuth token for any PR whose diff includes a workflow file, so the check fails on every workflow PR and the merge gate becomes a deadlock. Remove claude from required status checks — do NOT rename it. The Claude review check still runs on normal PRs and surfaces feedback without being a merge gate. See scripts/apply-rulesets.sh (post combsmith/.github#94) for the canonical required-checks list.

    Standard: standards/ci-standards.md#centralization-tiers

  4. don-petry commented on Apr 14, 2026

    @don-petry
    ContributorAuthor

    Claude finished @don-petry's task in 1m 57s —— View job


    Fixed: removed claude from required status checks

    • Gather context: read current scripts/apply-rulesets.sh
    • Check petry-projects/.github canonical required-checks list
    • Remove claude from required status checks in the code-quality ruleset
    • Verify fix applied correctly

    What was done

    The code-quality branch ruleset on this repository included claude as a required status check. This caused a deadlock on any PR that modified .github/workflows/ files because claude-code-action's GitHub App refuses to mint an OAuth token for workflow-touching PRs, making the check permanently fail.

    The fix was applied directly via the GitHub API — claude has been removed from the required status checks. The updated required checks now match the canonical list from petry-projects/.github/scripts/apply-rulesets.sh (which explicitly notes that claude must NOT be a required check):

    Check Status
    SonarCloud ✅ kept
    Analyze (javascript-typescript) ✅ kept
    Analyze (actions) ✅ kept
    Lint ✅ kept
    Format check ✅ kept
    Type check ✅ kept
    Tests ✅ kept
    claude ❌ removed

    The Claude review check still runs on normal PRs and provides feedback — it just no longer blocks merges.

    No code change was needed; this was a repository settings fix applied via the GitHub Rulesets API.

  5. don-petry commented on Apr 17, 2026

    @don-petry
    ContributorAuthor

    Resolved! This check is now passing as of 2026-04-17. Closing automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit finding

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions