Repository navigation
ci(sonar): report to the combsmith SonarCloud organization - #1338
Conversation
Moves sonar.organization / sonar.projectKey (and the related fixtures, badges and audit defaults) from the petry-projects SonarCloud organization to the new combsmith one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #1338 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a26c638f85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| ORG: ${{ github.repository_owner }} | ||
| SONAR_ORG: petry-projects | ||
| SONAR_ORG: ${{ github.repository_owner }} |
There was a problem hiding this comment.
When any repository is still registered only under petry-projects—the staged state described here, where this commit migrates .github after only the markets pilot—this override makes the weekly fleet audit enumerate only combsmith. The same run then calls close_resolved for every GitHub repository, and close_resolved interprets every absent group as resolved, so it will close valid audit issues and stop reporting findings for repositories not yet moved. Scan both Sonar organizations, or disable closures, until the fleet migration is verified rather than switching the destructive audit in one step.
AGENTS.md reference: AGENTS.md:L419-L426
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed: added a CLOSE_RESOLVED switch (default true) in scripts/sonarcloud-audit.sh that skips close_resolved in main, and set CLOSE_RESOLVED: 'false' in .github/workflows/sonarcloud-audit.yml until the fleet migration is verified. Repos still only under petry-projects no longer get their audit issues auto-closed.
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-14T22:27:32Z. |
|
CodeRabbit comment contains only a review rate-limit notice and no findings sections; no action needed. |
|
Codex summary table only reports review status (completed); its one finding is the review thread, addressed separately. |
|
SonarCloud reports Quality Gate Passed; no findings. |
Follow-up to the org rename: moves this repo's SonarCloud config from the
petry-projectsSonarCloud organization to the newcombsmithone (piloted on combsmith/markets#530: analysis succeeded with the existingSONAR_TOKENonce Automatic Analysis was off).5 files changed, 9 insertions(+), 9 deletions(-)
🤖 Generated with Claude Code
Problem
See the linked issue.
Risk
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
Tests added/updated:
test/scripts/compliance-audit/sonar-s7637-exemption.bats,test/scripts/sonarcloud-audit/pure-helpers.bats. Verification:bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.