Repository navigation
feat: implement issue #646 — [Phase 3] Add local canonical-AGENTS.md self-validation to CI (informational) - #1060
Conversation
…self-validation to CI (informational)
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new BATS test suite (test/workflows/ci/agents-md-selfcheck.bats) to act as a regression guard for the informational AGENTS.md self-check in the CI workflow. The tests verify that the linter script is executed in informational mode, outputs warnings instead of failing, and is properly documented. The review feedback highlights a fragility in the step_block_with helper function, which could incorrectly append subsequent job definitions to a step block, and provides a more robust parsing implementation using indentation checks.
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
CodeAnt Nitpicks1 code suggestion1. The workflow comments already contain
|
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
…lse-positives Strip comment lines before asserting AGENTS.md appears in the linter step, and verify the combined `scripts/agents-md-lint.sh … AGENTS.md` invocation pattern rather than just the script name alone. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
CI checks on this PR are still running. Once they complete, re-mention Posted by the donpetry-bot PR-review cascade. |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: MEDIUM
Reviewed commit: 7f34f901f75f10d5ec65574cb87bd8f1a346969a
Review mode: triage-approved (single reviewer)
Summary
Adds a non-blocking, informational AGENTS.md structural self-check job to ci.yml (Phase 3 of epic #642) plus a bats regression suite pinning its informational contract. Job follows org security standards: SHA-pinned checkout, minimal contents:read permissions, 10-minute timeout, no untrusted-input interpolation. Confirms the triage assessment; all decision gates pass.
Linked issue analysis
Closes #646. All four acceptance criteria are substantively met: (1) the linter runs against the repo's canonical AGENTS.md on every PR in informational mode, (2) findings surface as GitHub ::warning:: annotations (with and without line numbers), (3) the job is documented as deliberately NOT a required status check with promotion deferred to Phase 4 — and a bats test pins that contract, (4) the change is workflow wiring only; ShellCheck and YAML validity checks are green. Note: the issue's Dev Notes named lint.yml as the likely target, but this repo's lint jobs (Lint, ShellCheck) actually live in ci.yml, so placing the job there is the correct interpretation.
Findings
- No security findings. The new job uses a SHA-pinned actions/checkout, contents:read permissions, a timeout, and no ${{ }} expression interpolation in the run block.
- Secret scan: the run_secret_scanning MCP tool was not available in this run; the gitleaks CI check passed and the diff contains no credential-like content.
- Prior review feedback resolved at head: the codeant-ai thread about weak assertions was addressed in commit 7f34f90 — the tests now strip comment lines and assert the combined 'scripts/agents-md-lint.sh … AGENTS.md' invocation pattern, with an author reply on the thread (thread not formally marked resolved, but substantively closed).
- Minor, non-blocking: the '::warning:: annotations' bats test matches the raw step block including comments, which themselves contain '::warning::', so that single test could pass trivially. The workflow does emit real annotations; consider stripping comments in that test too in a follow-up.
CI status
All code checks green: Lint, ShellCheck, bats (CI Workflow Tests + Dependency Hardening), CodeQL, SonarCloud (quality gate passed, 0 new issues), gitleaks secret scan, Agent Security Scan, AgentShield, duplicate-decl-gate, dependency-audit, and the new AGENTS.md Self-Check job itself. Two CANCELLED entries (dev-lead dispatch / ci-relay) are the authoring agent's own orchestration jobs, not code checks. mergeStateStatus BLOCKED reflects only the pending review requirement.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
User description
Closes #646
Implemented by dev-lead agent. Please review.
CodeAnt-AI Description
Add informational AGENTS.md validation to pull request CI
What Changed
AGENTS.mdfor structural issuesImpact
✅ Earlier visibility into AGENTS.md issues✅ Clearer file- and line-specific CI warnings✅ Pull requests remain unblocked by self-check findings💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.