Repository navigation
chore(security): remove local SECURITY.md and stop seeding stub in repo-template - #2399
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Policy link and seeded baseline README.md, SECURITY.md, scripts/seed-repo-template.sh, tests/fixtures/seed-repo-template/*, tests/test_seed_repo_template.bats |
The README links to the organization-wide Security Policy. The seeder no longer includes or generates SECURITY.md; its generated inventories, fixtures, and tests now describe the policy as inherited organization-wide. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Merge Risk: 
Minimal · up to 79b2e
-
The policy inheritance change is consistent across documentation, seeding, fixtures, and tests.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Description check
-
Explanation
The description includes the required Summary, Problem, Risk, Test plan, Rollback, and Monitoring sections. It provides specific rationale, validation commands, rollback guidance, and monitoring details. The optional Interaction contract section is appropriately omitted because this PR does not change an agentic role.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|



Summary
SECURITY.mdincombsmith/.github-privateso it inherits the canonical org-wide policy incombsmith/.github/SECURITY.mddirectly.scripts/seed-repo-template.shso new and templated repositories do not receive a 6-line localSECURITY.mdpointer stub that shadowscombsmith/.github/SECURITY.mdand drops OpenSSF ScorecardSecurity-Policyscores from10/10to9/10.Problem
When a repository defines a local
SECURITY.md, both GitHub and OpenSSF Scorecard evaluate only that local file and ignorecombsmith/.github/SECURITY.md. Becauseseed-repo-template.sh(_gen_baseline) previously emitted a 6-lineSECURITY.mdpointer stub, every templated repository failed Scorecard'ssecurityPolicyContainsVulnerabilityDisclosureprobe (9/10, e.g.,combsmith/incubator#17,combsmith/repo-template#6,combsmith/empower-personal-dashboard#59), whereas repositories without a localSECURITY.mdinheritcombsmith/.github/SECURITY.mdand score10/10.Risk
Low — removing
"SECURITY.md|gen"fromBASELINE_MANIFESTstops seeding the 6-line stub intocombsmith/repo-template; existing repositories are updated via companion PRs.Test plan
bats tests/test_seed_repo_template.batsshellcheck -S warning -s bash scripts/seed-repo-template.shRollback
Revert this PR commit to restore
SECURITY.mdgeneration inseed-repo-template.sh.Monitoring
Verify
org-scorecard.ymlincombsmith/.githubresolvesgithub.com/combsmith/.github/SECURITY.md(10/10) across templated repositories.