Skip to content

feat: implement issue #2373 — [Fleet Monitor] combsmith/.github-private — .github/workflows/sync-scope-guard.yml #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 1 commit into from
Oct 21, 2026
Merged

feat: implement issue #2373 — [Fleet Monitor] combsmith/.github-private — .github/workflows/sync-scope-guard.yml #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ calling it a regression, and treat CI as authoritative.**
Because this is a **gate** workflow whose `failure` conclusion is intentional enforcement (it blocks a
bad PR), it is exempt from the Fleet Monitor's high-failure issue tracking via `FLEET_GATE_WORKFLOWS`
in `scripts/fleet_report.sh` (#941) — otherwise a guard doing its job produces false-positive trackers.
`holdout-guard.yml` is exempt for the same reason. Add new gate workflows of this class to that list.
`holdout-guard.yml` and `sync-scope-guard.yml` (which fails closed on a sync PR with no declared-paths
manifest or an out-of-scope diff, #1700/#2373) are exempt for the same reason. Add new gate workflows of
this class to that list.
- **Exception:** `pr-review-sweep.yml` (stuck-review sweep, #573/#898) is a documented repo-specific
workflow with no corresponding org template in `standards/workflows/`. It re-dispatches reviews for PRs
that went green after a ci-pending/ci-failing skip, via two triggers: a scheduled cron (the EVENTUAL
Expand Down
2 changes: 1 addition & 1 deletion scripts/fleet_report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# (#941). Matched by workflow file basename. See AGENTS.md "Exception:
# test-deletion-guard.yml". Override via env with the full space-separated
# gate list for testing; add permanent gates to the default below.
FLEET_GATE_WORKFLOWS="${FLEET_GATE_WORKFLOWS:-test-deletion-guard.yml holdout-guard.yml}"
FLEET_GATE_WORKFLOWS="${FLEET_GATE_WORKFLOWS:-test-deletion-guard.yml holdout-guard.yml sync-scope-guard.yml}"

# Dev-Lead status-marker prefix (#1019, story C of #901). Mirrors
# ISSUE_MARKER_PREFIX in dev-lead-fix-issue.sh / dev-lead-retry.sh: every
Expand Down
10 changes: 10 additions & 0 deletions tests/fleet_report.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,16 @@ _mk_metrics() {
rm -f "$m"
}

@test "filter_high_failure: sync-scope-guard gate over 10% is excluded (#2373)" {
local m
m="$(_mk_metrics \
$'1\tcombsmith/.github-private\t.github/workflows/sync-scope-guard.yml\t8\t4\t2\t2\t25.0%\t25\t1380\tDEGRADED\t25')"
run filter_high_failure "$m"
[ "$status" -eq 0 ]
[ "$(echo "$output" | jq 'length')" -eq 0 ]
rm -f "$m"
}

@test "filter_high_failure: non-gate workflow over 10% is still tracked" {
local m
m="$(_mk_metrics \
Expand Down
Loading