Skip to content

chore(seed): mirror repo-template#259 — BOOTSTRAP.md no longer prompts for or installs BMAD - #2377

Merged
don-petry merged 1 commit into
mainfrom
chore/mirror-repo-template-259
Oct 20, 2026
Merged

don-petry merged 1 commit into
mainfrom
chore/mirror-repo-template-259

Conversation

@don-petry

@don-petry don-petry commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Re-mirrors BOOTSTRAP.md from combsmith/repo-template main (3e073f87, #259) into the seeder heredoc, its fixture and its blob pin. #259 removed the BMAD input and the npx bmad-method install step from the runbook; step 8 now states that agent frameworks are vendored as git subtree from this repo (or software-factory), never installed per repo, and never prompted for. Companion: combsmith/.github#1366 aligns the org AGENTS.md.

Problem

scripts/seed-repo-template.sh (_gen_baseline) carries repo-template's BOOTSTRAP.md as a heredoc that is blob-pinned by tests/fixtures/seed-repo-template/repo-template-BOOTSTRAP.md and REPO_TEMPLATE_BOOTSTRAP_BLOB. Until it is mirrored, the next seed run would overwrite repo-template's BOOTSTRAP.md with the pre-#259 text, re-introducing the BMAD prompt and the npx install step the maintainer forbade on 2026-10-20.

Risk

Low — content-only change to one heredoc body, one fixture and three test constants. AGENTS.md and README.md pins are untouched (repo-template main's copies are unchanged since #258).

Test plan

  • bash scripts/seed-repo-template.sh --emit-baseline BOOTSTRAP.md | diff - <repo-template main BOOTSTRAP.md> → identical.
  • git hash-object of the newline-stripped fixture = 18f42406609dcb019362fc012c2ffc70b5c8de43 = new REPO_TEMPLATE_BOOTSTRAP_BLOB.
  • bats tests/test_seed_repo_template.bats (bash 5): 100/101. The one failure, test 60 "README.md section is read from the standard", is the pre-existing BSD sed -i -e incompatibility on macOS (sed: -e: No such file or directory); it is unrelated to this diff and green in CI.
  • DRY_RUN=true bash scripts/seed-repo-template.sh --repo combsmith/repo-template → would SKIP AGENTS.md, would SKIP README.md, would SKIP BOOTSTRAP.md, PASS (dry-run).
  • shellcheck -S warning scripts/seed-repo-template.sh clean.

Rollback

Revert this PR. The seeder would then re-emit the pre-#259 BOOTSTRAP.md on its next run, which is the regression this PR prevents.

Monitoring

The bats job on this PR (10–13 min on this repo); the next scheduled seed run reporting SKIP for BOOTSTRAP.md on combsmith/repo-template.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

…s for or installs BMAD

combsmith/repo-template#259 (main 3e073f87) removed the `BMAD` input and the
`npx bmad-method install` step from BOOTSTRAP.md: agent frameworks are vendored
as `git subtree` from this repo (or software-factory), never installed per repo,
and an agent never prompts for it. The seeder's BOOTSTRAP.md heredoc is
blob-pinned to repo-template main, so without this mirror the next seed run
would revert #259.

- scripts/seed-repo-template.sh: BOOTSTRAP.md heredoc body replaced with
  repo-template main's BOOTSTRAP.md byte-for-byte (emission diff-identical).
- tests/fixtures/seed-repo-template/repo-template-BOOTSTRAP.md refreshed
  (trailing newline stripped, as the seeder's $() capture writes it).
- tests/test_seed_repo_template.bats: REPO_TEMPLATE_BOOTSTRAP_BLOB →
  18f4240…; commit reference e0f994b0 (#258) → 3e073f87 (#259) in all
  three places. AGENTS.md / README.md pins unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner October 20, 2026 23:10
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e8cf2460-c4bb-49e5-9ca8-91eb84d38a15
📥 Commits

Reviewing files that changed from the base of the PR and between 4d0ec86 and 5fdf379.

📒 Files selected for processing: 3
  • scripts/seed-repo-template.sh
  • tests/fixtures/seed-repo-template/repo-template-BOOTSTRAP.md
  • tests/test_seed_repo_template.bats
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

QA Lead — test-risk advisory

Risk tier: LOW. This change only edits text in one heredoc, one fixture and three test constants. The existing blob-identity test already proves that the emitted BOOTSTRAP.md matches the fixture byte for byte.

What I'd shore up (highest leverage first):

  • Upstream drift is still checked by hand. The blob pin proves the heredoc matches the fixture. It does not prove the fixture matches repo-template main. That link is the manual diff in the test plan, and this PR exists because that link went stale. A cheap scheduled or advisory CI check would catch the next drift before a seed run does: compare git hash-object of repo-template's BOOTSTRAP.md (read-only API fetch) against REPO_TEMPLATE_BOOTSTRAP_BLOB. Make it non-blocking so it can't flake the PR gate on network failures.
  • Add a negative test for the specific regression. Assert that the --emit-baseline BOOTSTRAP.md output contains no `BMAD` table row and no BMAD=yes. The blob pin covers this today. When the next re-pin updates the SHA, though, the forbidden prompt could come back unnoticed. A targeted assertion keeps the maintainer's 2026-10-20 decision protected across future mirrors.
  • Pre-existing: test 60 fails locally on macOS because BSD sed -i -e behaves differently. It's unrelated to this diff and passes in CI. Still, a portable sed call (or a temp file plus mv) would make local runs report 101/101, so local results can be trusted.

Escalate? No.

Advisory only. I comment; I don't change code. Ground: BMAD Test Architecture (bmad-tea v1.19.0). Add the qa-lead:hands-off label to opt this item out.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Validation results (head 5fdf3790)

bash scripts/seed-repo-template.sh --emit-baseline BOOTSTRAP.md | diff - <(git -C repo-template show origin/main:BOOTSTRAP.md)
→ identical (repo-template main 3e073f87, #259)

git hash-object tests/fixtures/seed-repo-template/repo-template-BOOTSTRAP.md
18f42406609dcb019362fc012c2ffc70b5c8de43      # = REPO_TEMPLATE_BOOTSTRAP_BLOB

PATH=/opt/homebrew/bin:$PATH bats tests/test_seed_repo_template.bats     # bash 5.3
1..101 → 100 ok, 1 not ok
not ok 60 #2233: README.md section is read from the standard, not a copy in the script
#   sed: -e: No such file or directory      ← BSD sed `-i -e` incompatibility, pre-existing on macOS, green in CI

DRY_RUN=true bash scripts/seed-repo-template.sh --repo combsmith/repo-template
  [dry-run] would SKIP AGENTS.md — unchanged (AC #3) (no change)
  [dry-run] would SKIP README.md — unchanged (AC #3) (no change)
  [dry-run] would SKIP BOOTSTRAP.md — unchanged (AC #3) (no change)
[seed] PASS (dry-run) — combsmith/repo-template

shellcheck -S warning scripts/seed-repo-template.sh → clean

Commit reference e0f994b0 (#258) → 3e073f87 (#259) updated in all three places in tests/test_seed_repo_template.bats; AGENTS.md and README.md blob pins unchanged.

Will admin-merge (squash, no branch delete — merge queue) under the standing authorization once required checks are green and all review threads are resolved.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge October 20, 2026 23:11
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-21T00:11:43Z.

@don-petry
don-petry merged commit cc22580 into main Oct 20, 2026
57 checks passed
@don-petry
don-petry deleted the chore/mirror-repo-template-259 branch October 20, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants