[don-petry]

Follow-up to the org rename: moves this repo's SonarCloud config from the petry-projects SonarCloud organization to the new combsmith one (piloted on combsmith/markets#530: analysis succeeded with the existing SONAR_TOKEN once Automatic Analysis was off).

2 files changed, 4 insertions(+), 4 deletions(-)

🤖 Generated with Claude Code

Problem

See the linked issue.

Risk

Low — changes automation shell logic under scripts/, covered by shellcheck (--severity=warning) and the bats suite.

Test plan

No test files were added or updated. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's Lint (shellcheck) and bats checks show pass/fail; watch subsequent dev-lead / pr-review runs for behavioral regressions.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-14T21:27:57.471763Z	6a3fe80	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 035d326d-8825-4b9a-a0e8-05cc78107ffb

📥 Commits

Reviewing files that changed from the base of the PR and between de0e0ee and 6a3fe80.

📒 Files selected for processing: 2

• scripts/seed-repo-template.sh
• sonar-project.properties

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

• Chores
  • Updated the generated SonarCloud configuration to use the combsmith_repo-template project key and combsmith organization. Other project settings remain unchanged.

The SonarCloud organization and project keys change in the checked-in properties file and in the configuration generated by the repository template script.

Changes: SonarCloud configuration

Layer / File(s)	Summary
Update SonarCloud project identity scripts/seed-repo-template.sh, sonar-project.properties	The template script and properties file now use the combsmith organization and updated project keys.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6a3fe

The configuration changes align the checked-in repository and template with the combsmith organization. No concrete merge-blocking regression is established; proceed with normal checks.

Pre-merge checks: 5

Passed checks: 5 passed

Check name	Status	Explanation
Description check		The description includes the required Summary, Problem, Risk, Test plan, Rollback, and Monitoring sections. Some details are inaccurate or incomplete: the Problem section does not identify the linked …
Title check		The title clearly and concisely describes the main change: updating SonarCloud reporting to the combsmith organization.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[don-petry]

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #2332
No changes were committed, but the PR still can't be marked done: required checks SonarCloud, dependency-audit / Detect ecosystems are still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-10-14T21:53:00Z

[don-petry]

Note

@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required checks SonarCloud, dependency-audit / Detect ecosystems are still pending. I'll re-check automatically.
Next attempt after: 2026-10-14T21:53:00Z

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[don-petry]

QA Lead — test-risk advisory

Risk tier: LOW. This changes four lines of config. Nothing in production depends on it, and a revert undoes it completely. The only thing that can break is where CI sends its analysis, and this PR's own run shows that works: the SonarCloud Code Analysis check passed against combsmith_.github-private in the new organization.

What I'd shore up (highest leverage first):

• Check the first scan on main after merge. The PR run only covers the pull-request analysis. The branch analysis that runs on push and in the merge queue (-Dsonar.branch.name=main) creates a fresh project, so its "new code" baseline starts from zero. Confirm the quality gate on main stays green, or set the baseline on purpose, so the required SonarCloud check doesn't block the merge queue.
• The seeded template is not tested. scripts/seed-repo-template.sh now emits combsmith_repo-template, but tests/test_seed_repo_template.bats only checks that sonar-project.properties exists, not what it contains. A small assertion (no petry-projects string in the seeded output) would catch any leftover from the rename.
• Fix the PR body. The auto-filled Risk and Test plan sections say "automation shell logic… bats suite". That doesn't describe this change. The real verification is the passing SonarCloud check, and the body should say so.

Escalate? no

Advisory only — I comment, I do not change code. Ground: BMAD Test Architecture
(bmad-tea v1.19.0). Opt out on this item with the qa-lead:hands-off label.