Repository navigation
feat: implement issue #2327 — [ADR-0007] Record the markets pilot's measured baseline and post-collapse cost in the package (§1, §7, §11) - #2328
Conversation
…easured baseline and post-collapse cost in the package (§1, §7, §11)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in docs/initiatives/agent-ingress-collapse-markets.md to record the measured baseline and post-collapse metrics for the agent ingress collapse initiative. It includes detailed workflow run counts, billed jobs, and billing minutes, concluding that the collapse is cost-neutral to slightly cheaper. Additionally, the status table has been updated to reflect completed tasks, including the filed companion issue, published template, and applied fleet monitor rows. There are no review comments, and I have no feedback to provide.
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #2328 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-14T04:00:59Z. |
This comment has been minimized.
This comment has been minimized.
|
This is a neutral overview indicating the PR is safe to merge with no actionable issues — no code changes are required. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 023108c5d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Companion issue filed in markets | **Filed — markets#506** | Body as committed in §10. | | ||
| | Canonical `agent-ingress.yml` template published | **Published — petry-projects/.github#1316 (`452ea69`)** | Outside `DEPLOYABLE_WORKFLOWS` (§9b). | | ||
| | `STUB_REGISTRY` rows activated in fleet_monitor.sh | **Applied — #2182** | ALIGNED run observed: Fleet Monitor run 38193525415 (§9a/§9c). | |
There was a problem hiding this comment.
Reconcile completed statuses with the earlier sections
These completed statuses directly contradict the package sections they reference: §9b still labels template publication DEFERRED and says it cannot be done, §9c says registry activation is premature because markets is pre-collapse, and §10 says filing the companion issue remains outstanding. Since this document is the package's source of truth, readers now receive mutually exclusive operational instructions; update those sections to describe the completed work (or clearly mark their text as historical) along with this table.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in §9b, §9c and §10: §9b is now marked done and cites .github#1316, §9c is marked historical with the conditions noted as met (#2182, markets#513), and §10 now says the companion issue was filed as markets#506.
There was a problem hiding this comment.
§9b, §9c and §10 were reconciled earlier; this pass also fixed the remaining parent §9 heading/lead and the §9a marker note so the whole package reads as completed.
There was a problem hiding this comment.
§9, §9b, §9c and §10 already read as completed in earlier commits (verified again this pass); this pass also corrected the §9a note so it no longer contradicts the applied registry.
…atuses in §9b/§9c/§10
Dev-Lead — fix-reviews (partial)A commit was pushed, but not every requested change was applied. Per requested item:
The unaddressed items above still need work. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 704c32b7a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| > because publishing the canonical template is the cross-repo step below. | ||
|
|
||
| ### 9b. Canonical `agent-ingress.yml` template — publish is cross-repo (DEFERRED) | ||
| ### 9b. Canonical `agent-ingress.yml` template — publish was cross-repo (DONE) |
There was a problem hiding this comment.
Align the parent section with the completed activation
The fresh evidence in this revision is that §9b now says DONE and §9c says the rows are applied, while the unchanged §9 heading still says “prepared, activation deferred,” its lead says the two pieces cannot be completed, and line 839 says activation will land later. Because this package is the operational source of truth, readers are still told both that activation happened and that it remains deferred; update the parent heading, lead, and future-tense conclusion to reflect the completed state.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
§9 heading now reads 'done: template published, activation applied', the lead says both pieces are done, and §9c's closing line is past tense pointing to §11.
There was a problem hiding this comment.
The §9 heading, lead and §9c closing line already describe the completed activation (earlier commits); verified again this pass, and the §9a note was aligned with the applied registry.
|
No description provided. |
This comment has been minimized.
This comment has been minimized.
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
|
Codex review completed with no actionable findings. The comment is a neutral overview confirming the review ran successfully. |
Review — fix requested (cycle 3/3)The automated review identified the following issues. Please address each one: Findings to fixAutomated review — NEEDS HUMAN REVIEWRisk: LOW SummaryDocs-only change to docs/initiatives/agent-ingress-collapse-markets.md recording the markets pilot baseline (§1a), post-collapse measurements (§7a) and final status (§9–§11). The figures match #2327 and §3 is untouched. Escalating for three reasons: the PR deliberately departs from the issue's prescribed wording and conclusion, two review threads are still unresolved, and the non-required bats check is red (the same failure exists on main). Linked issue analysisCloses #2327. All three requested gaps are filled, and every number matches the issue: §1a has the 1342-run baseline table and window, §7a has the per-day table, other figures and raw totals, and §11 has each row at its final state plus the new AC7 row. §3 is unchanged, as the issue requires. Departures from the issue's explicit instructions (maintainer sign-off needed):
These edits came from bot review feedback (Codex/CodeRabbit) and may well be more accurate. Still, they override wording the maintainer specified ("Copy the figures below verbatim" and "Conclusion to state: …"), so a human should accept the reframing or restore the issue's text. Findings
Security: no secrets, credentials or workflow changes; docs only. The secret-scanning MCP tool isn't available in this run; gitleaks passed. CI statusAll required checks pass (SonarCloud, CodeQL, AgentShield, dependency-audit, duplicate-decl-gate). bats (Lint) FAILED on Reviewed automatically by the PR-review agent (single-reviewer mode: opus 5.5 [opus 4.8, opus 4.7]). Reply if you need a human review. Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
Problem
[ADR-0007] Record the markets pilot's measured baseline and post-collapse cost in the package (§1, §7, §11)
From the issue: The ADR-0007 markets pilot (#1729) is finalized. Its measured cost and final status are recorded in the #1729 comment #1729 (comment). The package doc
docs/initiatives/agent-ingress-collapse-markets.mdstill has three gaps:Risk
Low — documentation/configuration only; no runtime code paths change.
Test plan
No test files were added or updated. Verification:
bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
n/a — no runtime effect; documentation/configuration only.
Closes #2327