feat: implement issue #2206 — Sync the markets collapse package §3/§4a/§5a to markets#521 (pr-review repinned to pr-review/v1-stable) by don-petry · Pull Request #2207 · combsmith/.github-private

don-petry · 2026-10-10T17:02:32Z

Problem

Sync the markets collapse package §3/§4a/§5a to markets#521 (pr-review repinned to pr-review/v1-stable)

From the issue: combsmith/markets#521 (merged 2026-10-10 13:13Z) repointed the markets ingress's pr-review job from the legacy bare channel pr-review/stable to pr-review/v1-stable. It changed both the uses: line and with.agent_ref, and dropped the # DEFECTIVE PIN — see §5 marker. This fixes the defect the collapse package names in §5a.

Risk

Low — 2 file(s) changed; no CI- or runtime-critical paths touched.

Test plan

Tests added/updated: tests/fixtures/agent-ingress/markets-pinned-reusables/pr-review.yml. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's CI checks (Lint + bats) are the success/regression signal.

Closes #2206

…a/§5a to markets#521 (pr-review repinned to pr-review/v1-stable)

chatgpt-codex-connector · 2026-10-10T17:02:36Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

gemini-code-assist

Code Review

This pull request updates the documentation and test fixtures for the agent ingress collapse initiative to reflect the resolution of a defective pin. Specifically, the 'pr-review' job pin has been updated from the stale '@pr-review/stable' channel to the stable '@pr-review/v1-stable' channel, aligning with markets#521. As there are no review comments, I have no additional feedback to provide.

codeant-ai · 2026-10-10T17:05:16Z

CodeAnt PR Risk: Low Risk

The PR appears safe to merge; it updates the documented pin and matching reusable-workflow snapshot to the same version.
The change is limited to documentation and a test fixture, with no production workflow behavior changed in this diff.

Assessed commit: c56ceb679b3d

donpetry-bot · 2026-10-10T17:08:27Z

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-10T18:08:26Z.

don-petry · 2026-10-10T17:08:39Z

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

don-petry · 2026-10-10T17:10:26Z

QA Lead — test-risk advisory

Risk tier: LOW. This PR changes a doc and the header comments of one test fixture. The fixture's actual contents (the workflow_call inputs and the concurrency group) are unchanged. I compared them against pr-review.yml at 71920a2: the four inputs match and the group text matches as far as I checked. Production impact is close to zero.

What I'd shore up (highest leverage first):

Check the pr-review job by name. The test "each role job uses the target recorded in its own snapshot" only checks pr-auto-review and ci-failure-analyst. The PINNED-USES loop only confirms the pin appears somewhere in .jobs[].uses. Add a check that pr-review's uses: equals its snapshot's PINNED-USES line. That makes the guard follow the job this PR repins.
Check that uses: and with.agent_ref agree. markets#521 had to change the pin in both places. Nothing in the tests checks that agent_ref matches the ref after @ in uses:. One small yq test per role would catch the two drifting apart again.
The "byte-identical to markets 62587ec" claim is only in prose. No test enforces it. If it matters, keep a hash of §3 next to the fixtures and check it offline. Don't add a live cross-repo fetch, which would make CI flaky.
I couldn't run bats here because it isn't installed. The CI "Lint + bats" checks need to be green on this branch before merge.

Escalate? no

Advisory only — I comment, I do not change code. Ground: BMAD Test Architecture
(bmad-tea v1.19.0). Opt out on this item with the qa-lead:hands-off label.

donpetry-bot · 2026-10-10T17:39:47Z

No description provided.

donpetry-bot · 2026-10-10T17:50:21Z

No description provided.

don-petry · 2026-10-10T17:56:49Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

**However, there is one Tier 1 blocker that cannot be fixed from this PR:**
### template-drift CI check failure
The `template-drift` check is failing because `petry-projects/repo-template`'s `.github/workflows/dev-lead.yml` is out of sync with the standards-derived baseline. This is a **pre-existing issue not caused by this PR's changes** — the drift was already present on the main branch before this PR's merge.
**Status:** There is already **PR #235 open on repo-template** to fix this drift (automatically detected by the `seed-repo-template.sh` script). Once that PR merges, this check will pass. This PR cannot fix an issue in a separate repo.
**Files analyzed:**
- No code changes needed in this repo for the drift issue
- CodeRabbit rate-limit notice dispositioned
**Dispositions:**
- CodeRabbit rate-limit notice: `informational` ✓ (posted)
- template-drift failure: Pre-existing blocker in separate repo (PR #235 on repo-template pending)

don-petry · 2026-10-10T18:12:27Z

No description provided.

donpetry-bot · 2026-10-10T18:27:34Z

No description provided.

don-petry · 2026-10-10T18:30:20Z

No description provided.

don-petry · 2026-10-10T20:12:06Z

No description provided.

donpetry-bot · 2026-10-10T20:26:54Z

No description provided.

don-petry · 2026-10-10T20:27:47Z

No description provided.

don-petry · 2026-10-10T20:34:34Z

Dev-Lead — fix-reviews (no-changes)

Agent reasoning

Addressed 0 threads. There were no open review threads, so I made no commits, replies or markers.
- **Phase 0, reviews:** The only review is Gemini's `COMMENTED` overview. It is neutral and there is no `CHANGES_REQUESTED`, so nothing to act on.
- **Phase 0, CI:** One check is red, `template-drift`. It fails because `.github/workflows/dev-lead.yml` in `petry-projects/repo-template` differs from the standards-derived baseline (blob `5b5adde0e8dc`, expected `df3236d8e9e4`).
- **Why I left it:** This PR only changes `docs/initiatives/agent-ingress-collapse-markets.md` and `tests/fixtures/agent-ingress/markets-pinned-reusables/pr-review.yml`, and neither is a template stub. The check's own message says to re-seed the template with `scripts/seed-repo-template.sh` and not to hand-edit it. That change belongs in `repo-template`, outside this PR. I did not confirm whether `main` has the same failure. My lookup of the `main` run returned nothing for this check.
- **Phase 1 and 1b:** No threads. I did not enumerate issue comments for Phase 1b.
- **Phase 2:** I did not run the test suite because I changed no code. The other CI checks (`bats`, `unit-tests`, `shellcheck` and the rest) are green.
- **Phases 3:** Nothing changed, so there was nothing to review.
Files changed: none.
The PR stays blocked on `template-drift` until someone re-seeds the `repo-template` stub.

donpetry-bot · 2026-10-10T21:16:19Z

No description provided.

don-petry · 2026-10-10T21:27:32Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 1
- CodeRabbit rate-limit notice: Dispositioned as informational (operational notice, no code findings) [disposition reply posted]
Files changed: none
Skipped (informational): 1
```
**Summary:**
The CodeRabbit comment on PR #2207 is a **rate-limit operational notice** — it reports that the bot hit its free OSS review quota and will reset in 38 minutes. It contains no code findings, no security issues, and no specific defects. All finding-bearing sections (Security Architecture Review, Actionable comments, Nitpicks, etc.) are empty.
I posted a fresh disposition on the original comment with the `informational` marker and the required node ID (`IC_kwDOR9SdIs8AAAABa5a2cw`). The harness will resolve this comment and clear the maintainer-comment gate blocker.
No code changes are needed for this PR.

donpetry-bot · 2026-10-10T21:57:38Z

No description provided.

don-petry · 2026-10-10T22:10:33Z

Neutral overview with no actionable findings — CodeAnt assessment confirms the PR is safe to merge with no code changes required.

don-petry · 2026-10-10T22:10:46Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

- CodeAnt's "PR Risk: Low Risk" comment confirms the PR is safe to merge
- The comment contains no specific code defects or security issues
- All CI checks are passing (no failures, only successes and skipped checks)
- The review from `gemini-code-assist[bot]` is also non-actionable (COMMENTED state with no changes requested)
**Action taken:**
- Posted `informational` disposition reply on the CodeAnt comment (IC_kwDOR9SdIs8AAAABa5cNIA) to clear it from the maintainer-comment gate
**Issues addressed:** 0 (no code changes required)
**Files changed:** None
**Bot comment dispositioned:** Yes — `informational` (neutral overview, no findings)
The PR is ready for approval — no code changes were needed.

donpetry-bot · 2026-10-10T22:12:17Z

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-10T23:12:17Z.

don-petry · 2026-10-10T22:27:45Z

No description provided.

don-petry · 2026-10-10T22:47:57Z

Codex hit its usage limit for code reviews — an operational notice with no code findings. Nothing to change.

don-petry · 2026-10-10T22:47:58Z

SonarCloud reports Quality Gate Passed — no findings to address.

don-petry · 2026-10-10T22:48:06Z

Dev-Lead — fix-reviews (no-changes)

Agent reasoning

Addressed 0 threads. There were no open review threads, and I made no code changes and no commits.
- **Review state:** the only review is a neutral `COMMENTED` from gemini-code-assist, with no change requests.
- **CI:** every check passed or was skipped, except three `dev-lead / ci-relay`, `dispatch` and `resume` checks that show `cancelled`. Those are workflow runs, not code failures, so there is nothing to fix in the PR, and I did not re-run them.
- **Issue comments:** two bot notices had no disposition, so I replied to each with an `informational` marker. The Codex usage-limit notice had no findings, and SonarCloud reported Quality Gate Passed. Earlier passes had already handled the CodeRabbit and CodeAnt comments.
- **Tests:** not run, since there were no code changes.
Files changed: none.

donpetry-bot · 2026-10-10T22:49:12Z

No description provided.

don-petry · 2026-10-10T22:58:27Z

Rate-limit notice only — CodeRabbit exhausted its free OSS review allocation. No code findings to address, all finding-bearing sections empty.

don-petry · 2026-10-10T22:58:40Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

## Summary
**Bot:** coderabbitai[bot]
**Status:** No code changes needed
**Finding:** The comment is a rate-limit operational notice (CodeRabbit exhausted its free OSS review allocation). The entire comment is a throttle notice with no actual code findings, no Security Architecture Review section, and no actionable defects.
**Action taken:** Posted disposition reply with `informational` marker on the original comment (IC_kwDOR9SdIs8AAAABa5a2cw). The comment was edited after the prior disposition, so a fresh disposition was required to cover the current body.
**CI Status:** No Tier 1 blockers—all checks are queued, completed with success, or skipped.
**Files changed:** None
The PR is clear of actionable findings and ready for the harness to resolve the disposition and proceed.

sonarqubecloud · 2026-10-10T23:11:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

don-petry · 2026-10-10T23:13:15Z

No description provided.

feat: implement issue #2206 — Sync the markets collapse package §3/§4…

485645c

…a/§5a to markets#521 (pr-review repinned to pr-review/v1-stable)

don-petry requested a review from a team as a code owner October 10, 2026 17:02

don-petry added the auto-rebase:ready Opts a non-draft PR into auto-rebase without an approval (auto-rebase ready_label) label Oct 10, 2026

don-petry mentioned this pull request Oct 10, 2026

Sync the markets collapse package §3/§4a/§5a to markets#521 (pr-review repinned to pr-review/v1-stable) #2206

Closed

This comment has been minimized.

Sign in to view

gemini-code-assist Bot reviewed Oct 10, 2026

View reviewed changes

don-petry enabled auto-merge October 10, 2026 17:08

Merge branch 'main' into dev-lead/issue-2206-20261010-1658

1f3ded4

don-petry disabled auto-merge October 10, 2026 17:52

This comment has been minimized.

Sign in to view

don-petry enabled auto-merge October 10, 2026 17:56

Merge branch 'main' into dev-lead/issue-2206-20261010-1658

55f5cd3

Merge branch 'main' into dev-lead/issue-2206-20261010-1658

232e5b2

don-petry disabled auto-merge October 10, 2026 20:34

don-petry enabled auto-merge October 10, 2026 20:34

Merge branch 'main' into dev-lead/issue-2206-20261010-1658

3e798b9

don-petry disabled auto-merge October 10, 2026 21:26

This comment has been minimized.

Sign in to view

don-petry enabled auto-merge October 10, 2026 21:27

don-petry disabled auto-merge October 10, 2026 22:10

don-petry enabled auto-merge October 10, 2026 22:10

Merge branch 'main' into dev-lead/issue-2206-20261010-1658

1b92bd1

don-petry disabled auto-merge October 10, 2026 22:47

don-petry enabled auto-merge October 10, 2026 22:48

Merge branch 'main' into dev-lead/issue-2206-20261010-1658

c56ceb6

don-petry disabled auto-merge October 10, 2026 22:57

don-petry enabled auto-merge October 10, 2026 22:58

don-petry merged commit 28c7ed8 into main Oct 10, 2026
49 of 52 checks passed

don-petry deleted the dev-lead/issue-2206-20261010-1658 branch October 10, 2026 23:30

don-petry mentioned this pull request Oct 14, 2026

[Phase 3] Collapse the first repo's Class-1 event-driven stubs into agent-ingress.yml and rename the required checks #1729

Closed

5 tasks

Conversation

don-petry commented Oct 10, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Risk

Test plan

Rollback

Monitoring

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026

Uh oh!

This comment has been minimized.

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

codeant-ai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeAnt PR Risk: Low Risk

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Dev-Lead — review-changes (no-changes)

Uh oh!

don-petry commented Oct 10, 2026

QA Lead — test-risk advisory

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

This comment has been minimized.

don-petry commented Oct 10, 2026

Dev-Lead — fix-bot-comment (no-changes)

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Dev-Lead — fix-reviews (no-changes)

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

This comment has been minimized.

don-petry commented Oct 10, 2026

Dev-Lead — fix-bot-comment (no-changes)

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Dev-Lead — fix-bot-comment (no-changes)

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Dev-Lead — fix-reviews (no-changes)

Uh oh!

donpetry-bot commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

Uh oh!

don-petry commented Oct 10, 2026

don-petry commented Oct 10, 2026 •

edited by cubic-dev-ai Bot

Loading

codeant-ai Bot commented Oct 10, 2026 •

edited

Loading