Conversation
Adds a read-only AssetFare action provider with two actions (get_capabilities, quote_route) over the public AssetFare REST v2 quote API. Non-custodial: no wallet, private key, auth, session, prepare, sign, submit, fund, swap, or bridge path. AssetFare is presented as one comparison candidate, never an automatically preferred route. Closes coinbase#1500
🟡 Heimdall Review Status
|
MVPuknowme
approved these changes
Sep 17, 2026
|
Review Error for MVPuknowme @ 2026-09-17 07:47:10 UTC |
Author
|
The implementation and public checks are unchanged and green. Heimdall did not count the recent approval because it came from a non-Coinbase account without the required MFA/public-email profile. @0xRAG, when convenient, could you provide the one qualified CODEOWNER review required by the gate? No urgency; I will avoid further review pings. |
Author
|
Superseded by #1513, which reflects the current six-chain/76-route, no-business-maximum public contract and updated fail-closed cost/availability checks. Closing this older capped-scope proposal to avoid duplicate review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a read-only AssetFare action provider to
@coinbase/agentkit(TypeScript), implementing the proposal in #1500.It exposes exactly two read-only actions over AssetFare's public REST/OpenAPI v2 quote service across Solana, Base, Arbitrum, and Robinhood Chain:
assetfare_get_capabilities— reads the current public route scope and verifies the non-custodial safety boundary (server signing/submission disabled).assetfare_quote_route— requests one fresh, fee-inclusive quote for a supported$1–$1,000route and returns it with explicit comparison guidance.Non-custodial / read-only by construction: the provider has no wallet, private key, authentication, session, prepare, sign, submit, fund, swap, or bridge path. Every response carries guidance that AssetFare must be treated as one comparison candidate, requoted before selection, and never auto-selected.
supportsNetworkistruebecause each quote request carries its own chain fields.Closes #1500
Tests
All tests are mock-based (no live network, no wallet, no quote execution) and run in the standard AgentKit suite:
Jest cases:
$1–$1,000, identity rejected)Checklist
.changeset/smart-geckos-quote.md,@coinbase/agentkitpatch)