Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
| (SecurityCategoriesAcl, IDScopeLowerCase): ReplaceMethod( | ||
| self.client.lookup.security_categories.id, | ||
| self.client.lookup.security_categories.external_id, | ||
| id_name="ids", | ||
| ), | ||
| (cap.TimeSeriesAcl, cap.TimeSeriesAcl.Scope.ID): ReplaceMethod( | ||
| (TimeSeriesAcl, IDScopeLowerCase): ReplaceMethod( | ||
| self.client.lookup.time_series.id, | ||
| self.client.lookup.time_series.external_id, | ||
| id_name="ids", |
There was a problem hiding this comment.
Bug caught by replacing SDK.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors GroupIO to import ACL and Scope classes directly from the toolkit's group resource classes rather than using cognite.client capabilities, updating scope and ACL name lookups to use Pydantic model_fields defaults. It also adds support for IDScopeLowerCase for datasets and extraction pipelines, and updates the unit test import violation count. Feedback is provided regarding a redundant try-except block in load_resource that catches a broad Exception only to re-raise it, which violates the repository's error handling style guide.
This branch has not been deployed
1 participant
Description
Using our own scope and acl definitions instead. This lead me to accidentally find this bug.
Bump
Changelog
Fixed
securityCategoriesAclortimeSeriesAcl, Toolkit nor correctly does a lookup of security category names and timeseries IDs.