Skip to content

[CDF-26503] 🦋Support paused trigger - #3318

Merged
doctrino merged 7 commits into
mainfrom
support-paused-trigger
Oct 5, 2026
Merged

doctrino merged 7 commits into
mainfrom
support-paused-trigger

Conversation

@doctrino

@doctrino doctrino commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Description

Please describe the change you have made.

Bump

  • Patch
  • Skip

Changelog

Added

  • [alpha - v09 ]Added support for pausing a workflow trigger by setting the isPaused property on a WorkflowTrigger YAML file.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@doctrino
doctrino marked this pull request as ready for review October 4, 2026 09:57
@doctrino
doctrino requested review from a team as code owners October 4, 2026 09:57
@doctrino

doctrino commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for pausing and resuming workflow triggers via the is_paused property, guarded by the V09 feature flag. Feedback suggests raising a ResourceCreationError if a pause or resume state change is requested while the V09 feature flag is disabled, preventing silent failures.

Comment thread cognite_toolkit/_cdf_tk/resource_ios/_workflow.py
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
43755 37172 85% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/client/resource_classes/workflow_trigger.py 100% 🟢
cognite_toolkit/_cdf_tk/resource_ios/_workflow.py 85% 🟢
cognite_toolkit/_cdf_tk/yaml_classes/workflow_trigger.py 96% 🟢
TOTAL 94% 🟢

updated for commit: ae38cfc by action🐍

@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.95%. Comparing base (9542082) to head (ae38cfc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cognite_toolkit/_cdf_tk/resource_ios/_workflow.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3318      +/-   ##
==========================================
- Coverage   85.55%   84.95%   -0.61%     
==========================================
  Files         463      463              
  Lines       45574    43755    -1819     
==========================================
- Hits        38991    37172    -1819     
  Misses       6583     6583              
Files with missing lines Coverage Δ
...cdf_tk/client/resource_classes/workflow_trigger.py 100.00% <100.00%> (+1.69%) ⬆️
...e_toolkit/_cdf_tk/yaml_classes/workflow_trigger.py 95.65% <100.00%> (-0.13%) ⬇️
cognite_toolkit/_cdf_tk/resource_ios/_workflow.py 85.22% <95.45%> (+0.39%) ⬆️

... and 193 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@doctrino
doctrino enabled auto-merge (squash) October 4, 2026 10:05
@doctrino
doctrino merged commit efd7073 into main Oct 5, 2026
14 checks passed
@doctrino
doctrino deleted the support-paused-trigger branch October 5, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants