Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a default client timeout of 60 seconds, suggests increasing it via the 'CDF_CLIENT_TIMEOUT' environment variable on request failures, and enforces a minimum of one task in workflow definitions. Feedback recommends dynamically initializing the default timeout constant from the environment variable and improving the error message's formatting.
doctrino
changed the title
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3317 +/- ##
==========================================
- Coverage 85.55% 84.95% -0.61%
==========================================
Files 463 463
Lines 45574 43747 -1827
==========================================
- Hits 38991 37165 -1826
+ Misses 6583 6582 -1
🚀 New features to boost your workflow:
|
| if request.connect_attempt > 1: | ||
| message += ( | ||
| f"\n You can try to increase the timeout by setting the 'CDF_CLIENT_TIMEOUT' " | ||
| f"environment variable. {os.environ.get('CDF_CLIENT_TIMEOUT', DEFAULT_CLIENT_TIMEOUT)}" |
There was a problem hiding this comment.
| f"environment variable. {os.environ.get('CDF_CLIENT_TIMEOUT', DEFAULT_CLIENT_TIMEOUT)}" | |
| f"environment variable. Timeout is currently set to {os.environ.get('CDF_CLIENT_TIMEOUT', DEFAULT_CLIENT_TIMEOUT)}s" |
| COGNITE_CLI_KEYRING_SERVICE = "cognite-cli-session" | ||
| COGNITE_CLI_ACCESS_TOKEN_LEEWAY_SECONDS = 5 * 60 | ||
|
|
||
| DEFAULT_CLIENT_TIMEOUT = 60 |
There was a problem hiding this comment.
There is a bit of a discrepancy unless we also change EnvironmentVariables.CDF_CLIENT_TIMEOUT (commands/auth/data_classes/_environment_variables.py:120) as this is currently set to 30 and not 60
This branch has not been deployed
2 participants
Description
Combined two minor improvements to avoid having two PRs.
Check workflow version tasks on build instead of deploy
now
this PR
Bump
Changelog
Improved
cdf buildinstead ofcdf deploy.Fixed
ResourceViewMappingToolkit always treat the propertyview.versionas a string in the YAML file.