Skip to content

[CDF-28612]😎 Handle failed loading of TOML - #3316

Open
doctrino wants to merge 6 commits into
mainfrom
better-error-message
Open

doctrino wants to merge 6 commits into
mainfrom
better-error-message

Conversation

@doctrino

@doctrino doctrino commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Before

image

After

image

Bump

  • Patch
  • Skip

Changelog

Improved

  • If Toolkit fails to load your cdf.toml, it no longer shows a long traceback, but instead shows a short concise error message.

@doctrino
doctrino requested review from a team as code owners October 2, 2026 14:13
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@doctrino
doctrino enabled auto-merge (squash) October 2, 2026 14:15
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
43735 37155 85% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/cdf_toml.py 78% 🟢
cognite_toolkit/_cdf_tk/commands/_base.py 90% 🟢
cognite_toolkit/_cdf_tk/commands/about.py 95% 🟢
cognite_toolkit/_cdf_tk/commands/build_v2/build_v2.py 91% 🟢
cognite_toolkit/_cdf_tk/commands/init.py 73% 🟢
cognite_toolkit/_cdf_tk/commands/modules.py 66% 🟢
cognite_toolkit/_cdf_tk/feature_flags.py 100% 🟢
cognite_toolkit/_cdf_tk/hints.py 39% 🟢
cognite_toolkit/_cdf_tk/plugins.py 88% 🟢
cognite_toolkit/_cdf_tk/resource_ios/_function.py 88% 🟢
cognite_toolkit/_cdf_tk/utils/file.py 79% 🟢
TOTAL 81% 🟢

updated for commit: 72fc63f by action🐍

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.95%. Comparing base (2a40499) to head (72fc63f).

Files with missing lines Patch % Lines
cognite_toolkit/_cdf_tk/cdf_toml.py 50.00% 4 Missing ⚠️
cognite_toolkit/_cdf_tk/commands/modules.py 50.00% 1 Missing ⚠️
cognite_toolkit/_cdf_tk/hints.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3316      +/-   ##
==========================================
- Coverage   85.55%   84.95%   -0.61%     
==========================================
  Files         463      463              
  Lines       45567    43735    -1832     
==========================================
- Hits        38985    37155    -1830     
+ Misses       6582     6580       -2     
Files with missing lines Coverage Δ
cognite_toolkit/_cdf_tk/commands/_base.py 89.61% <100.00%> (ø)
cognite_toolkit/_cdf_tk/commands/about.py 94.69% <100.00%> (ø)
...nite_toolkit/_cdf_tk/commands/build_v2/build_v2.py 91.40% <100.00%> (-0.03%) ⬇️
cognite_toolkit/_cdf_tk/commands/init.py 73.33% <100.00%> (-0.87%) ⬇️
cognite_toolkit/_cdf_tk/feature_flags.py 100.00% <100.00%> (ø)
cognite_toolkit/_cdf_tk/plugins.py 88.23% <100.00%> (-1.24%) ⬇️
cognite_toolkit/_cdf_tk/resource_ios/_function.py 87.88% <100.00%> (ø)
cognite_toolkit/_cdf_tk/utils/file.py 79.27% <100.00%> (ø)
cognite_toolkit/_cdf_tk/commands/modules.py 65.69% <50.00%> (ø)
cognite_toolkit/_cdf_tk/hints.py 38.82% <50.00%> (ø)
... and 1 more

... and 190 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant