Skip to content

fix(inline-tool-link): restore unlink behavior and add dynamic tooltip with keyboard Shortcut #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prathmeshyelne wants to merge 1 commit into
base: next
Choose a base branch
from
+27 −15
Open

fix(inline-tool-link): restore unlink behavior and add dynamic tooltip with keyboard Shortcut #3008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/components/inline-tools/inline-tool-link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export default class LinkInlineTool implements InlineTool {
this.nodes.button.classList.add(this.CSS.button, this.CSS.buttonModifier);

this.nodes.button.innerHTML = IconLink;
this.nodes.button.title = LinkInlineTool.title;

return this.nodes.button;
}
Expand Down Expand Up @@ -172,21 +173,11 @@ export default class LinkInlineTool implements InlineTool {
* Unlink icon pressed
*/
if (parentAnchor) {
/**
* If input is not opened, treat click as explicit unlink action.
* If input is opened (e.g., programmatic close when switching tools), avoid unlinking.
*/
if (!this.inputOpened) {
this.selection.expandToTag(parentAnchor);
this.unlink();
this.closeActions();
this.checkState();
this.toolbar.close();
} else {
/** Only close actions without clearing saved selection to preserve user state */
this.closeActions(false);
this.checkState();
}
this.selection.expandToTag(parentAnchor);
this.unlink();
this.closeActions();
this.checkState();
this.toolbar.close();

return;
}
Expand All @@ -205,6 +196,7 @@ export default class LinkInlineTool implements InlineTool {
this.nodes.button.innerHTML = IconUnlink;
this.nodes.button.classList.add(this.CSS.buttonUnlink);
this.nodes.button.classList.add(this.CSS.buttonActive);
this.nodes.button.title = 'Unlink';
this.openActions();

/**
Expand All @@ -219,6 +211,7 @@ export default class LinkInlineTool implements InlineTool {
this.nodes.button.innerHTML = IconLink;
this.nodes.button.classList.remove(this.CSS.buttonUnlink);
this.nodes.button.classList.remove(this.CSS.buttonActive);
this.nodes.button.title = 'Link';
}

return !!anchorTag;
Expand All @@ -238,6 +231,13 @@ export default class LinkInlineTool implements InlineTool {
return 'CMD+K';
}

/**
* Returns dynamic title based on whether the current selection is inside a link
*/
public getTitle(): string {
return this.selection.findParentTag('A') ? 'Unlink' : 'Link';
}

/**
* Show/close link input
*/
Expand Down
12 changes: 12 additions & 0 deletions src/components/modules/toolbar/inline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,18 @@ export default class InlineToolbar extends Module<InlineToolbarNodes> {
instance.checkState?.(SelectionUtils.get());
}

/**
* Allow inline tools to provide a dynamic title based on current selection state
*/
const dynamicTitle = (instance as { getTitle?: () => string }).getTitle?.();

if (dynamicTitle !== undefined) {
(popoverItem as PopoverItemHtmlParams).hint = {
...(popoverItem as PopoverItemHtmlParams).hint,
title: dynamicTitle,
};
}

popoverItems.push(popoverItem);
} else if (item.type === PopoverItemType.Html) {
/**
Expand Down
Loading